[PR #18940] [MERGED] 18417 Add outer_height to racks #15481

Closed
opened 2025-12-30 00:22:11 +01:00 by adam · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/18940
Author: @arthanson
Created: 3/18/2025
Status: Merged
Merged: 3/26/2025
Merged by: @jeremystretch

Base: featureHead: 18417-rack-height


📝 Commits (10+)

  • 2283f6f 18417 add rack outer height
  • 604ef7b 18417 add rack outer height
  • 1dc249c 18417 fix tests
  • 807ba45 18417 fix validation message
  • 55aadb6 Merge branch 'feature' into 18417-rack-height
  • fb56e5b Update netbox/dcim/filtersets.py
  • abd8de2 Update netbox/dcim/filtersets.py
  • 92fc311 Update netbox/dcim/models/racks.py
  • 70ea60f Update netbox/dcim/models/racks.py
  • a2e552f Update netbox/dcim/models/racks.py

📊 Changes

12 files changed (+128 additions, -49 deletions)

View changed files

📝 docs/models/dcim/racktype.md (+1 -1)
📝 netbox/dcim/api/serializers_/racks.py (+5 -5)
📝 netbox/dcim/filtersets.py (+4 -4)
📝 netbox/dcim/forms/bulk_edit.py (+16 -8)
📝 netbox/dcim/forms/bulk_import.py (+2 -2)
📝 netbox/dcim/forms/model_forms.py (+7 -6)
netbox/dcim/migrations/0203_add_rack_outer_height.py (+23 -0)
📝 netbox/dcim/models/racks.py (+17 -10)
📝 netbox/dcim/tables/racks.py (+22 -13)
📝 netbox/dcim/tables/template_code.py (+5 -0)
📝 netbox/dcim/tests/test_filtersets.py (+16 -0)
📝 netbox/templates/dcim/inc/panels/racktype_dimensions.html (+10 -0)

📄 Description

Fixes: #18417

Adds outer_height to racks / rack_types to complement the existing outer_width.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/18940 **Author:** [@arthanson](https://github.com/arthanson) **Created:** 3/18/2025 **Status:** ✅ Merged **Merged:** 3/26/2025 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `feature` ← **Head:** `18417-rack-height` --- ### 📝 Commits (10+) - [`2283f6f`](https://github.com/netbox-community/netbox/commit/2283f6fdf6d211040ac08e03c5455aae3774c201) 18417 add rack outer height - [`604ef7b`](https://github.com/netbox-community/netbox/commit/604ef7b8e453b82623b5ff4a0db7d0729c44ffa7) 18417 add rack outer height - [`1dc249c`](https://github.com/netbox-community/netbox/commit/1dc249c13fc04bd454a4aba6e4cb5f6d1f8be185) 18417 fix tests - [`807ba45`](https://github.com/netbox-community/netbox/commit/807ba450d7cfedd14ab0a3c1ac92ffca958d0908) 18417 fix validation message - [`55aadb6`](https://github.com/netbox-community/netbox/commit/55aadb69aeaac1181f904b3903c2d8e01996460f) Merge branch 'feature' into 18417-rack-height - [`fb56e5b`](https://github.com/netbox-community/netbox/commit/fb56e5baa9d46bb152bc62ee0239e7ea2032e32d) Update netbox/dcim/filtersets.py - [`abd8de2`](https://github.com/netbox-community/netbox/commit/abd8de2e502ffeb2c62edcf54960c8c2aa6d4cce) Update netbox/dcim/filtersets.py - [`92fc311`](https://github.com/netbox-community/netbox/commit/92fc311ff2b8eb73e6e2dc3681eca7932586298b) Update netbox/dcim/models/racks.py - [`70ea60f`](https://github.com/netbox-community/netbox/commit/70ea60fd2930da7b0a0e5bca0b8f37bb92965560) Update netbox/dcim/models/racks.py - [`a2e552f`](https://github.com/netbox-community/netbox/commit/a2e552fca1bb6c8ba339147de6d6f3c26cbeda0a) Update netbox/dcim/models/racks.py ### 📊 Changes **12 files changed** (+128 additions, -49 deletions) <details> <summary>View changed files</summary> 📝 `docs/models/dcim/racktype.md` (+1 -1) 📝 `netbox/dcim/api/serializers_/racks.py` (+5 -5) 📝 `netbox/dcim/filtersets.py` (+4 -4) 📝 `netbox/dcim/forms/bulk_edit.py` (+16 -8) 📝 `netbox/dcim/forms/bulk_import.py` (+2 -2) 📝 `netbox/dcim/forms/model_forms.py` (+7 -6) ➕ `netbox/dcim/migrations/0203_add_rack_outer_height.py` (+23 -0) 📝 `netbox/dcim/models/racks.py` (+17 -10) 📝 `netbox/dcim/tables/racks.py` (+22 -13) 📝 `netbox/dcim/tables/template_code.py` (+5 -0) 📝 `netbox/dcim/tests/test_filtersets.py` (+16 -0) 📝 `netbox/templates/dcim/inc/panels/racktype_dimensions.html` (+10 -0) </details> ### 📄 Description ### Fixes: #18417 Adds outer_height to racks / rack_types to complement the existing outer_width. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 00:22:11 +01:00
adam closed this issue 2025-12-30 00:22:11 +01:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#15481