starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #18901] [MERGED] Fixes #18872: JournalEntry kind is a required field #15469

New Issue
Closed
opened 2025-12-30 00:22:07 +01:00 by adam · 0 comments
adam commented 2025-12-30 00:22:07 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/18901
Author: @jeremystretch
Created: 3/13/2025
Status: ✅ Merged
Merged: 3/19/2025
Merged by: @bctiemann

Base: main ← Head: 18872-JournalEntry-kind-required

📝 Commits (1)

📊 Changes

2 files changed (+27 additions, -3 deletions)

View changed files

📝 netbox/extras/forms/model_forms.py (+2 -3)
➕ netbox/extras/migrations/0123_journalentry_kind_default.py (+25 -0)

📄 Description

Fixes: #18872

  • Mark kind as a required field on JournalEntryForm
  • Include a migration to update any journal entries with no kind assigned to "info"

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/18901 **Author:** [@jeremystretch](https://github.com/jeremystretch) **Created:** 3/13/2025 **Status:** ✅ Merged **Merged:** 3/19/2025 **Merged by:** [@bctiemann](https://github.com/bctiemann) **Base:** `main` ← **Head:** `18872-JournalEntry-kind-required` --- ### 📝 Commits (1) - [`994e7eb`](https://github.com/netbox-community/netbox/commit/994e7eb9f4583d5cbcb73dcbb0d6211c4ac05f0d) Fixes #18872: JournalEntry kind is a required field ### 📊 Changes **2 files changed** (+27 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `netbox/extras/forms/model_forms.py` (+2 -3) ➕ `netbox/extras/migrations/0123_journalentry_kind_default.py` (+25 -0) </details> ### 📄 Description ### Fixes: #18872 - Mark `kind` as a required field on JournalEntryForm - Include a migration to update any journal entries with no kind assigned to "info" --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 00:22:07 +01:00
adam closed this issue 2025-12-30 00:22:07 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#15469
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?