starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #18889] [MERGED] Fixes: #18783 Add a tag_id filter for all models which support tagging #15467

New Issue
Closed
opened 2025-12-30 00:22:06 +01:00 by adam · 0 comments
adam commented 2025-12-30 00:22:06 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/18889
Author: @renatoalmeidaoliveira
Created: 3/13/2025
Status: ✅ Merged
Merged: 3/25/2025
Merged by: @arthanson

Base: main ← Head: 18783-Add-a-tag_id-filter-for-all-models-which-support-tagging

📝 Commits (4)

  • aa518ff Create TagIDFilter replicating TagFilter logic, and implemented at NetBoxModelFilterSet and ConfigTemplateFilterSet
  • 32b0508 Add TagIDFilter to all
  • 41deeb4 Documentation update
  • 06d4421 Fix docs typo

📊 Changes

4 files changed (+41 additions, -2 deletions)

View changed files

📝 docs/plugins/development/filtersets.md (+21 -0)
📝 netbox/extras/filters.py (+16 -0)
📝 netbox/extras/filtersets.py (+2 -1)
📝 netbox/netbox/filtersets.py (+2 -1)

📄 Description

Fixes: #18783 Add a tag_id filter for all models which support tagging

Replicate TagFilter logic to TagIDFilter and implemented tag_id field to NetBoxModelFilterSet and ConfigTemplateFilterSet

Tested the FilterSet in REST, GraphQL, and in the UI by crafting an URL.

Since there already a Tag field in the FilterForm didn't implemented any new field.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/18889 **Author:** [@renatoalmeidaoliveira](https://github.com/renatoalmeidaoliveira) **Created:** 3/13/2025 **Status:** ✅ Merged **Merged:** 3/25/2025 **Merged by:** [@arthanson](https://github.com/arthanson) **Base:** `main` ← **Head:** `18783-Add-a-tag_id-filter-for-all-models-which-support-tagging` --- ### 📝 Commits (4) - [`aa518ff`](https://github.com/netbox-community/netbox/commit/aa518ff2e6f308853ccd05da412927c741bf519c) Create TagIDFilter replicating TagFilter logic, and implemented at NetBoxModelFilterSet and ConfigTemplateFilterSet - [`32b0508`](https://github.com/netbox-community/netbox/commit/32b05080d5175c4c3397faaeb0dff46dc83b613a) Add TagIDFilter to __all__ - [`41deeb4`](https://github.com/netbox-community/netbox/commit/41deeb4dc9d9f58fae752e10dba781efe3aa0cef) Documentation update - [`06d4421`](https://github.com/netbox-community/netbox/commit/06d4421e41bacc33ac1c856b9f632d6db76fd19c) Fix docs typo ### 📊 Changes **4 files changed** (+41 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `docs/plugins/development/filtersets.md` (+21 -0) 📝 `netbox/extras/filters.py` (+16 -0) 📝 `netbox/extras/filtersets.py` (+2 -1) 📝 `netbox/netbox/filtersets.py` (+2 -1) </details> ### 📄 Description ### Fixes: #18783 Add a tag_id filter for all models which support tagging Replicate `TagFilter` logic to `TagIDFilter` and implemented `tag_id` field to `NetBoxModelFilterSet` and `ConfigTemplateFilterSet` Tested the FilterSet in REST, GraphQL, and in the UI by crafting an URL. Since there already a Tag field in the FilterForm didn't implemented any new field. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 00:22:06 +01:00
adam closed this issue 2025-12-30 00:22:07 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#15467
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?