[PR #18818] [MERGED] Fixes: #18579 Add contact filters to services #15445

New Issue

adam · 2025-12-30T00:21:57+01:00

adam commented

2025-12-30 00:21:57 +01:00

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/18818
Author: @renatoalmeidaoliveira
Created: 3/5/2025
Status: ✅ Merged
Merged: 3/6/2025
Merged by: @jnovinger

Base: main ← Head: 18579-contact-filters

📝 Commits (10+)

0afaacf Add Contact filter to Services
22c3d5f Add ContactModelFilterForm to ProviderAccountFilterForm
433013c Add Contact filter support for Aggregate
0f7a663 Add Contact filter support for Prefix
99423af Add Contact filter to IPRange
aaa9496 Add Contact filter to IPAddress
b51f613 Add Contact filter to L2VPN
cf2a60c Add Contact filter to TunnelGroup
d1af106 Add Contact filter to Tunnel
85e2277 Add ContactModelFilterSet to ProviderAccountFilterSet

📊 Changes

6 files changed (+35 additions, -22 deletions)

View changed files

📝 netbox/circuits/filtersets.py (+1 -1)
📝 netbox/circuits/forms/filtersets.py (+2 -1)
📝 netbox/ipam/filtersets.py (+7 -6)
📝 netbox/ipam/forms/filtersets.py (+11 -6)
📝 netbox/vpn/filtersets.py (+4 -4)
📝 netbox/vpn/forms/filtersets.py (+10 -4)

📄 Description

Fixes: #18579 Add contact filters to services

Added the ContactModelFilterSet to every ModelFilterSet where it was missing
Added ContactModelFilterForm to every ModelFilterForm where it was missing
Added the appropriated FieldSet for Contacts

As @bctiemann commented in the issue, there were several other model classes with ContactsMixin that didn’t have the appropriate fields and filters.
The following models were fixed in this PR:

Services
ProviderAccount
Aggregate
Prefix
IPRange
IPAddress
L2VPN
TunnelGroup
Tunnel

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/18818 **Author:** [@renatoalmeidaoliveira](https://github.com/renatoalmeidaoliveira) **Created:** 3/5/2025 **Status:** ✅ Merged **Merged:** 3/6/2025 **Merged by:** [@jnovinger](https://github.com/jnovinger) **Base:** `main` ← **Head:** `18579-contact-filters` --- ### 📝 Commits (10+) - [`0afaacf`](https://github.com/netbox-community/netbox/commit/0afaacf2d77e8f02f35fea0ab2ad895080429f5e) Add Contact filter to Services - [`22c3d5f`](https://github.com/netbox-community/netbox/commit/22c3d5f0adcf732bdcab2a1c5037b64c89164858) Add ContactModelFilterForm to ProviderAccountFilterForm - [`433013c`](https://github.com/netbox-community/netbox/commit/433013c79e2bef6618dee5091012e81ef88906b0) Add Contact filter support for Aggregate - [`0f7a663`](https://github.com/netbox-community/netbox/commit/0f7a663f13d9c6ef9dd0e053e716e34d7c60038a) Add Contact filter support for Prefix - [`99423af`](https://github.com/netbox-community/netbox/commit/99423af0f7ccb0cb904e5760236de134a198c079) Add Contact filter to IPRange - [`aaa9496`](https://github.com/netbox-community/netbox/commit/aaa94969faa8652e913e2f55cae4753ec62ed527) Add Contact filter to IPAddress - [`b51f613`](https://github.com/netbox-community/netbox/commit/b51f613010591d685bf336993b839a93acc14d2f) Add Contact filter to L2VPN - [`cf2a60c`](https://github.com/netbox-community/netbox/commit/cf2a60c6f7684da7bd5ae201e5690a618ccf3174) Add Contact filter to TunnelGroup - [`d1af106`](https://github.com/netbox-community/netbox/commit/d1af106c8ce138560d37281863609353c4809b6e) Add Contact filter to Tunnel - [`85e2277`](https://github.com/netbox-community/netbox/commit/85e2277f055bf31cbd29c53e0be8ba48fabc9f72) Add ContactModelFilterSet to ProviderAccountFilterSet ### 📊 Changes **6 files changed** (+35 additions, -22 deletions) <details> <summary>View changed files</summary> 📝 `netbox/circuits/filtersets.py` (+1 -1) 📝 `netbox/circuits/forms/filtersets.py` (+2 -1) 📝 `netbox/ipam/filtersets.py` (+7 -6) 📝 `netbox/ipam/forms/filtersets.py` (+11 -6) 📝 `netbox/vpn/filtersets.py` (+4 -4) 📝 `netbox/vpn/forms/filtersets.py` (+10 -4) </details> ### 📄 Description ### Fixes: #18579 Add contact filters to services - Added the `ContactModelFilterSet` to every `ModelFilterSet` where it was missing - Added `ContactModelFilterForm` to every `ModelFilterForm` where it was missing - Added the appropriated `FieldSet` for `Contacts` As @bctiemann commented in the issue, there were several other model classes with ContactsMixin that didn’t have the appropriate fields and filters. The following models were fixed in this PR: - `Services` - `ProviderAccount` - `Aggregate` - `Prefix` - `IPRange` - `IPAddress` - `L2VPN` - `TunnelGroup` - `Tunnel` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-30 00:21:57 +01:00

adam closed this issue

2025-12-30 00:21:57 +01:00

Sign in to join this conversation.

Branches Tags

main

update-changelog-comments-docs

feature-removal-issue-type

20911-dropdown

20239-plugin-menu-classes-mutable-state

21097-graphql-id-lookups

feature

fix_module_substitution

20923-dcim-templates

20044-elevation-stuck-lightmode

feature-ip-prefix-link

v4.5-beta1-release

20068-import-moduletype-attrs

20766-fix-german-translation-code-literals

20378-del-script

7604-filter-modifiers-v3

circuit-swap

12318-case-insensitive-uniqueness

20637-improve-device-q-filter

20660-script-load

19724-graphql

20614-update-ruff

14884-script

02496-max-page

19720-macaddress-interface-generic-relation

19408-circuit-terminations-export-templates

20203-openapi-check

fix-19669-api-image-download

7604-filter-modifiers

19275-fixes-interface-bulk-edit

fix-17794-get_field_value_return_list

11507-show-aggregate-and-rir-on-api

9583-add_column_specific_search_field_to_tables

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/netbox#15445