starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #18802] [MERGED] Fixes: #18753 Webhooks trigger on custom script dry-run #15442

New Issue
Closed
opened 2025-12-30 00:21:57 +01:00 by adam · 0 comments
adam commented 2025-12-30 00:21:57 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/18802
Author: @renatoalmeidaoliveira
Created: 3/4/2025
Status: ✅ Merged
Merged: 3/5/2025
Merged by: @jeremystretch

Base: main ← Head: 18753-fix-event-for-scripts

📝 Commits (1)

  • 2ab6ecf Add commit test in job execution

📊 Changes

1 file changed (+6 additions, -3 deletions)

View changed files

📝 netbox/extras/jobs.py (+6 -3)

📄 Description

Fixes: #18753 Webhooks trigger on custom script dry-run

  • Added commit test as @jeremystretch commented in the issue
  • Followed the same wokring pattern as in v4.0.10 code
  • Tested with a simple script editing an IPAddress and the fix worked.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/18802 **Author:** [@renatoalmeidaoliveira](https://github.com/renatoalmeidaoliveira) **Created:** 3/4/2025 **Status:** ✅ Merged **Merged:** 3/5/2025 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `main` ← **Head:** `18753-fix-event-for-scripts` --- ### 📝 Commits (1) - [`2ab6ecf`](https://github.com/netbox-community/netbox/commit/2ab6ecfc2c22a8f17bcfabb1528e277cd15c86b2) Add commit test in job execution ### 📊 Changes **1 file changed** (+6 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `netbox/extras/jobs.py` (+6 -3) </details> ### 📄 Description ### Fixes: #18753 Webhooks trigger on custom script dry-run - Added commit test as @jeremystretch commented in the issue - Followed the same wokring pattern as in v4.0.10 [code](https://github.com/netbox-community/netbox/blob/e93e9ac4a093f26a6fd8f6a1d6bfb0bb49de20f6/netbox/extras/scripts.py#L703) - Tested with a simple script editing an IPAddress and the fix worked. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 00:21:57 +01:00
adam closed this issue 2025-12-30 00:21:57 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#15442
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?