starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #18804] [MERGED] Fixes: #18742 Location List and Locations not Showing Associated VLAN Groups #15441

New Issue
Closed
opened 2025-12-30 00:21:57 +01:00 by adam · 0 comments
adam commented 2025-12-30 00:21:57 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/18804
Author: @renatoalmeidaoliveira
Created: 3/4/2025
Status: ✅ Merged
Merged: 3/11/2025
Merged by: @bctiemann

Base: main ← Head: 18742-Location-List-and-Locations-not-Showing-Associated-VLAN-Groups

📝 Commits (1)

  • d83c2f4 Add vlangroup into LocationTable, LocationListView queryset and related_models in LocationView

📊 Changes

2 files changed (+29 additions, -14 deletions)

View changed files

📝 netbox/dcim/tables/sites.py (+8 -2)
📝 netbox/dcim/views.py (+21 -12)

📄 Description

Fixes: #18742 Location List and Locations not Showing Associated VLAN Groups

  • Added VLANGroup relation to LocationView related_models
  • Added vlangroup_count to LocationTable
  • Added another add_related_count to LocationListView queryset,

That add_related_count structure are used only in the LocationListView so it may not be very usefull to create a utily function to handle that kind of nested relations.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/18804 **Author:** [@renatoalmeidaoliveira](https://github.com/renatoalmeidaoliveira) **Created:** 3/4/2025 **Status:** ✅ Merged **Merged:** 3/11/2025 **Merged by:** [@bctiemann](https://github.com/bctiemann) **Base:** `main` ← **Head:** `18742-Location-List-and-Locations-not-Showing-Associated-VLAN-Groups` --- ### 📝 Commits (1) - [`d83c2f4`](https://github.com/netbox-community/netbox/commit/d83c2f45bc473cae23666c548d54309d924d26a7) Add vlangroup into LocationTable, LocationListView queryset and related_models in LocationView ### 📊 Changes **2 files changed** (+29 additions, -14 deletions) <details> <summary>View changed files</summary> 📝 `netbox/dcim/tables/sites.py` (+8 -2) 📝 `netbox/dcim/views.py` (+21 -12) </details> ### 📄 Description ### Fixes: #18742 Location List and Locations not Showing Associated VLAN Groups - Added VLANGroup relation to `LocationView` `related_models` - Added `vlangroup_count` to `LocationTable` - Added another `add_related_count` to `LocationListView` `queryset`, That `add_related_count` structure are used only in the `LocationListView` so it may not be very usefull to create a utily function to handle that kind of nested relations. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 00:21:57 +01:00
adam closed this issue 2025-12-30 00:21:57 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#15441
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?