starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #18791] [MERGED] Closes #17608: Adds L2VPN.status field #15437

New Issue
Closed
opened 2025-12-30 00:21:55 +01:00 by adam · 0 comments
adam commented 2025-12-30 00:21:55 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/18791
Author: @jnovinger
Created: 3/3/2025
Status: ✅ Merged
Merged: 3/6/2025
Merged by: @arthanson

Base: feature ← Head: 17608-add-L2VPN-status-field

📝 Commits (10+)

  • 2fb16f9 Adds L2VPN.status field, associated L2VPNStatusChoices, and migration
  • a2f3ad3 Adds color definitions to L2VPNStatusChoices
  • 7ca125f Updates forms and filtersets for L2VPN.status
  • 0ae134d Adds L2VPN.status to table/detail display
  • 6cf7d56 Adds L2VPN.status to API serializer
  • 651a452 Adds L2VPN.status to search results display
  • e24ec82 Fixes L2VPN view tests
  • 6f874ff Updates vpn.L2VPN docs
  • fef9805 Switch from 'decommissioned' choice to 'decommissioning'
  • 6aad455 Adds status field to L2VPN.clone_fields

📊 Changes

16 files changed (+169 additions, -25 deletions)

View changed files

📝 docs/models/vpn/l2vpn.md (+13 -0)
📝 netbox/templates/vpn/l2vpn.html (+4 -0)
📝 netbox/vpn/api/serializers_/l2vpn.py (+1 -1)
📝 netbox/vpn/choices.py (+14 -0)
📝 netbox/vpn/filtersets.py (+4 -1)
📝 netbox/vpn/forms/bulk_edit.py (+5 -1)
📝 netbox/vpn/forms/bulk_import.py (+5 -0)
📝 netbox/vpn/forms/filtersets.py (+6 -1)
📝 netbox/vpn/forms/model_forms.py (+3 -3)
➕ netbox/vpn/migrations/0008_add_l2vpn_status.py (+16 -0)
📝 netbox/vpn/models/l2vpn.py (+11 -2)
📝 netbox/vpn/search.py (+1 -1)
📝 netbox/vpn/tables/l2vpn.py (+6 -3)
📝 netbox/vpn/tests/test_api.py (+51 -6)
📝 netbox/vpn/tests/test_filtersets.py (+12 -0)
📝 netbox/vpn/tests/test_views.py (+17 -6)

📄 Description

Fixes: #17608

  • adds L2VPN.status field with L2VPNStatusChoices as choices
  • adds migration for L2VPN.status
  • updates forms and filtersets for L2VPN.status
  • updates UI views (tables and detail template) and API serializer for L2VPN.status
  • updates L2VPNIndex to display status in results
  • fixes tests to use new L2VPN.status field

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/18791 **Author:** [@jnovinger](https://github.com/jnovinger) **Created:** 3/3/2025 **Status:** ✅ Merged **Merged:** 3/6/2025 **Merged by:** [@arthanson](https://github.com/arthanson) **Base:** `feature` ← **Head:** `17608-add-L2VPN-status-field` --- ### 📝 Commits (10+) - [`2fb16f9`](https://github.com/netbox-community/netbox/commit/2fb16f969ea36f1dcea5a1d5e2565efc3caf7826) Adds L2VPN.status field, associated L2VPNStatusChoices, and migration - [`a2f3ad3`](https://github.com/netbox-community/netbox/commit/a2f3ad347930315e3f4c8dcbdd95556671c11919) Adds color definitions to L2VPNStatusChoices - [`7ca125f`](https://github.com/netbox-community/netbox/commit/7ca125f35de328b4a63bd1799356d42873ced888) Updates forms and filtersets for L2VPN.status - [`0ae134d`](https://github.com/netbox-community/netbox/commit/0ae134d40f468a1ea3c33a5e0e04e84e9344feb0) Adds L2VPN.status to table/detail display - [`6cf7d56`](https://github.com/netbox-community/netbox/commit/6cf7d56557c25074270e9d716a528ddceb262a98) Adds L2VPN.status to API serializer - [`651a452`](https://github.com/netbox-community/netbox/commit/651a452dc448d082f6655e7212f65156aed1a0b0) Adds L2VPN.status to search results display - [`e24ec82`](https://github.com/netbox-community/netbox/commit/e24ec8292f1e519a842bc991b76b2a0845f1e7b7) Fixes L2VPN view tests - [`6f874ff`](https://github.com/netbox-community/netbox/commit/6f874ff13369cadbb8924d67514d8eeef42bae6a) Updates vpn.L2VPN docs - [`fef9805`](https://github.com/netbox-community/netbox/commit/fef98057cb8b7082bf12a8b1d4d9b2651b5c1daf) Switch from 'decommissioned' choice to 'decommissioning' - [`6aad455`](https://github.com/netbox-community/netbox/commit/6aad45511f2846b9b07e4b87c4874448654a34e7) Adds status field to L2VPN.clone_fields ### 📊 Changes **16 files changed** (+169 additions, -25 deletions) <details> <summary>View changed files</summary> 📝 `docs/models/vpn/l2vpn.md` (+13 -0) 📝 `netbox/templates/vpn/l2vpn.html` (+4 -0) 📝 `netbox/vpn/api/serializers_/l2vpn.py` (+1 -1) 📝 `netbox/vpn/choices.py` (+14 -0) 📝 `netbox/vpn/filtersets.py` (+4 -1) 📝 `netbox/vpn/forms/bulk_edit.py` (+5 -1) 📝 `netbox/vpn/forms/bulk_import.py` (+5 -0) 📝 `netbox/vpn/forms/filtersets.py` (+6 -1) 📝 `netbox/vpn/forms/model_forms.py` (+3 -3) ➕ `netbox/vpn/migrations/0008_add_l2vpn_status.py` (+16 -0) 📝 `netbox/vpn/models/l2vpn.py` (+11 -2) 📝 `netbox/vpn/search.py` (+1 -1) 📝 `netbox/vpn/tables/l2vpn.py` (+6 -3) 📝 `netbox/vpn/tests/test_api.py` (+51 -6) 📝 `netbox/vpn/tests/test_filtersets.py` (+12 -0) 📝 `netbox/vpn/tests/test_views.py` (+17 -6) </details> ### 📄 Description <!-- Thank you for your interest in contributing to NetBox! Please note that our contribution policy requires that a feature request or bug report be approved and assigned prior to opening a pull request. This helps avoid waste time and effort on a proposed change that we might not be able to accept. IF YOUR PULL REQUEST DOES NOT REFERENCE AN ISSUE WHICH HAS BEEN ASSIGNED TO YOU, IT WILL BE CLOSED AUTOMATICALLY. Please specify your assigned issue number on the line below. --> ### Fixes: #17608 - adds `L2VPN.status` field with `L2VPNStatusChoices` as choices - adds migration for `L2VPN.status` - updates forms and filtersets for `L2VPN.status` - updates UI views (tables and detail template) and API serializer for `L2VPN.status` - updates `L2VPNIndex` to display `status` in results - fixes tests to use new `L2VPN.status` field <!-- Please include a summary of the proposed changes below. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 00:21:55 +01:00
adam closed this issue 2025-12-30 00:21:55 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#15437
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?