starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-14 06:13:32 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #18662] [MERGED] Fixes #18619: shift-select selects hidden items #15408

New Issue
Closed
opened 2025-12-30 00:21:45 +01:00 by adam · 0 comments
adam commented 2025-12-30 00:21:45 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/18662
Author: @jnovinger
Created: 2/18/2025
Status: ✅ Merged
Merged: 2/20/2025
Merged by: @jeremystretch

Base: main ← Head: 18619-shift-click-selection-selects-hidden

📝 Commits (1)

📊 Changes

3 files changed (+9 additions, -5 deletions)

View changed files

📝 netbox/project-static/dist/netbox.js (+1 -1)
📝 netbox/project-static/dist/netbox.js.map (+2 -2)
📝 netbox/project-static/src/buttons/selectMultiple.ts (+6 -2)

📄 Description

Fixes #18619: shift-select selects hidden items

This also fixes the inverse, when a range is unselected via shift-click, previously checked checkboxes that are hidden are not changed.

Changes:

  • adds tests to only change checkbox checked values if their parent tr is not hidden

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/18662 **Author:** [@jnovinger](https://github.com/jnovinger) **Created:** 2/18/2025 **Status:** ✅ Merged **Merged:** 2/20/2025 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `main` ← **Head:** `18619-shift-click-selection-selects-hidden` --- ### 📝 Commits (1) - [`f185e3c`](https://github.com/netbox-community/netbox/commit/f185e3c33036346aaaff983da80ea58c144b461c) Fixes #18619: shift-select selects hidden items ### 📊 Changes **3 files changed** (+9 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `netbox/project-static/dist/netbox.js` (+1 -1) 📝 `netbox/project-static/dist/netbox.js.map` (+2 -2) 📝 `netbox/project-static/src/buttons/selectMultiple.ts` (+6 -2) </details> ### 📄 Description ### Fixes #18619: shift-select selects hidden items This also fixes the inverse, when a range is unselected via shift-click, previously checked checkboxes that are hidden are not changed. Changes: - adds tests to only change checkbox `checked` values if their parent `tr` is not hidden --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 00:21:45 +01:00
adam closed this issue 2025-12-30 00:21:46 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#15408
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?