[PR #18602] [MERGED] Fixes: 18593 - "Create & Add Another" broken for new IP addresses #15389

New Issue

adam · 2025-12-30T00:21:38+01:00

adam commented

2025-12-30 00:21:38 +01:00

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/18602
Author: @renatoalmeidaoliveira
Created: 2/7/2025
Status: ✅ Merged
Merged: 2/11/2025
Merged by: @jeremystretch

Base: main ← Head: 18593-Create_and_add_another_fix

📝 Commits (2)

bea5373 update IPAddressEditView get_extra_addanother_params
a682351 Simplify get_extra_addanother_params

📊 Changes

1 file changed (+1 additions, -0 deletions)

View changed files

📝 netbox/ipam/views.py (+1 -0)

📄 Description

Fixes: #18593 - "Create & Add Another" broken for new IP addresses

Changes IPAddressEditView's get_extra_addanother_params to return super().get_extra_addanother_params(request) when the GET params interface or vminterface

Its also possible to solve this issue returning {} if there aren't any match in the if clauses, IMO returning super().get_extra_addanother_params(request) could be more flexible in the future.
Please let me know if you prefer to use another approach.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/18602 **Author:** [@renatoalmeidaoliveira](https://github.com/renatoalmeidaoliveira) **Created:** 2/7/2025 **Status:** ✅ Merged **Merged:** 2/11/2025 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `main` ← **Head:** `18593-Create_and_add_another_fix` --- ### 📝 Commits (2) - [`bea5373`](https://github.com/netbox-community/netbox/commit/bea5373b78c8de6aa482e049883e1164258494c5) update IPAddressEditView get_extra_addanother_params - [`a682351`](https://github.com/netbox-community/netbox/commit/a682351e587859ab3626ebc9914b0b61001a0464) Simplify get_extra_addanother_params ### 📊 Changes **1 file changed** (+1 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `netbox/ipam/views.py` (+1 -0) </details> ### 📄 Description ### Fixes: #18593 - "Create & Add Another" broken for new IP addresses * Changes IPAddressEditView's get_extra_addanother_params to return `super().get_extra_addanother_params(request)` when the GET params `interface` or `vminterface` Its also possible to solve this issue returning `{}` if there aren't any match in the if clauses, IMO returning `super().get_extra_addanother_params(request)` could be more flexible in the future. Please let me know if you prefer to use another approach. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-30 00:21:38 +01:00

adam closed this issue

2025-12-30 00:21:39 +01:00

Sign in to join this conversation.

Branches Tags

main

21142-device-component-graphql-filters

21050-device-oob-ip-may-become-orphaned

21102-fix-graphiql-explorer

20911-dropdown

20239-plugin-menu-classes-mutable-state

21097-graphql-id-lookups

feature

fix_module_substitution

20923-dcim-templates

20044-elevation-stuck-lightmode

feature-ip-prefix-link

v4.5-beta1-release

20068-import-moduletype-attrs

20766-fix-german-translation-code-literals

20378-del-script

7604-filter-modifiers-v3

circuit-swap

12318-case-insensitive-uniqueness

20637-improve-device-q-filter

20660-script-load

19724-graphql

20614-update-ruff

14884-script

02496-max-page

19720-macaddress-interface-generic-relation

19408-circuit-terminations-export-templates

20203-openapi-check

fix-19669-api-image-download

7604-filter-modifiers

19275-fixes-interface-bulk-edit

fix-17794-get_field_value_return_list

11507-show-aggregate-and-rir-on-api

9583-add_column_specific_search_field_to_tables

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/netbox#15389