starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-13 22:03:32 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #18551] [MERGED] Fixes: #18013 - All saved filters showing up for Change Log table, regardless of defined object type #15377

New Issue
Closed
opened 2025-12-30 00:21:35 +01:00 by adam · 0 comments
adam commented 2025-12-30 00:21:35 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/18551
Author: @renatoalmeidaoliveira
Created: 1/31/2025
Status: ✅ Merged
Merged: 2/6/2025
Merged by: @jeremystretch

Base: main ← Head: 18013-add-filter_id-query_params-ObjectChangeFilterForm-

📝 Commits (4)

  • 576abc1 Setup ObjectChangeFilterForm init to add query_param to filter_id
  • 621cda3 code lint, move init to end of class
  • 70531ca Move filter_id widget setup to SavedFiltersMixin, and add model attributes to Models FilterForms
  • e2117ec Add missing model declarations for filter forms

📊 Changes

4 files changed (+21 additions, -9 deletions)

View changed files

📝 netbox/core/forms/filtersets.py (+2 -0)
📝 netbox/extras/forms/filtersets.py (+9 -0)
📝 netbox/netbox/forms/base.py (+0 -9)
📝 netbox/netbox/forms/mixins.py (+10 -0)

📄 Description

Fixes: #18013 - All saved filters showing up for Change Log table, regardless of defined object type

Since ObjectChangeFilterForm doesn't inherid from NetBoxModelFilterSetForm the filter_id field doesn't get updated

Changes:

  • Add __init__ method to ObjectChangeFilterForm, and setup filter_id query_params

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/18551 **Author:** [@renatoalmeidaoliveira](https://github.com/renatoalmeidaoliveira) **Created:** 1/31/2025 **Status:** ✅ Merged **Merged:** 2/6/2025 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `main` ← **Head:** `18013-add-filter_id-query_params-ObjectChangeFilterForm-` --- ### 📝 Commits (4) - [`576abc1`](https://github.com/netbox-community/netbox/commit/576abc19e229098dcf3f3f21e76f82f4de28d93a) Setup ObjectChangeFilterForm __init__ to add query_param to filter_id - [`621cda3`](https://github.com/netbox-community/netbox/commit/621cda3edadf22b072115f348f122f182ccacfba) code lint, move __init__ to end of class - [`70531ca`](https://github.com/netbox-community/netbox/commit/70531ca725accf36172b09c7e770c1c82b628089) Move filter_id widget setup to SavedFiltersMixin, and add model attributes to Models FilterForms - [`e2117ec`](https://github.com/netbox-community/netbox/commit/e2117ecfb851b885970451d2774f78422892a520) Add missing model declarations for filter forms ### 📊 Changes **4 files changed** (+21 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `netbox/core/forms/filtersets.py` (+2 -0) 📝 `netbox/extras/forms/filtersets.py` (+9 -0) 📝 `netbox/netbox/forms/base.py` (+0 -9) 📝 `netbox/netbox/forms/mixins.py` (+10 -0) </details> ### 📄 Description ### Fixes: #18013 - All saved filters showing up for Change Log table, regardless of defined object type Since ObjectChangeFilterForm doesn't inherid from NetBoxModelFilterSetForm the filter_id field doesn't get updated Changes: * Add `__init__` method to ObjectChangeFilterForm, and setup filter_id `query_params` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 00:21:35 +01:00
adam closed this issue 2025-12-30 00:21:35 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#15377
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?