starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-13 22:03:32 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #18530] [MERGED] Closes: #18529 - Add auth_required attrib on PluginMenuItem #15367

New Issue
Closed
opened 2025-12-30 00:21:31 +01:00 by adam · 0 comments
adam commented 2025-12-30 00:21:31 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/18530
Author: @bctiemann
Created: 1/29/2025
Status: ✅ Merged
Merged: 1/31/2025
Merged by: @jeremystretch

Base: main ← Head: 18529-auth_required-on-PluginMenuItem

📝 Commits (1)

  • 1a0654a Add auth_required attrib on PluginMenuItem

📊 Changes

1 file changed (+2 additions, -1 deletions)

View changed files

📝 netbox/netbox/plugins/navigation.py (+2 -1)

📄 Description

Closes: #18529

This supports the ability of menu items associated with plugins to not be displayed if the user is not authenticated and LOGIN_REQUIRED is False.

This is not a breaking change for NetBox itself, hence targeting for 4.2.3. However note that plugins that use the auth_required attribute on their menu items will require NetBox 4.2.3.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/18530 **Author:** [@bctiemann](https://github.com/bctiemann) **Created:** 1/29/2025 **Status:** ✅ Merged **Merged:** 1/31/2025 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `main` ← **Head:** `18529-auth_required-on-PluginMenuItem` --- ### 📝 Commits (1) - [`1a0654a`](https://github.com/netbox-community/netbox/commit/1a0654a24c66e3213a01f9425c3f14b6a4b2c410) Add auth_required attrib on PluginMenuItem ### 📊 Changes **1 file changed** (+2 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `netbox/netbox/plugins/navigation.py` (+2 -1) </details> ### 📄 Description ### Closes: #18529 This supports the ability of menu items associated with plugins to not be displayed if the user is not authenticated and `LOGIN_REQUIRED` is `False`. This is not a breaking change for NetBox itself, hence targeting for 4.2.3. However note that plugins that use the `auth_required` attribute on their menu items will require NetBox 4.2.3. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 00:21:31 +01:00
adam closed this issue 2025-12-30 00:21:31 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#15367
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?