starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #18491] [MERGED] #17542 contact assignment to vpn tunnels #15359

New Issue
Closed
opened 2025-12-30 00:21:28 +01:00 by adam · 0 comments
adam commented 2025-12-30 00:21:28 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/18491
Author: @antoinekh
Created: 1/25/2025
Status: ✅ Merged
Merged: 2/25/2025
Merged by: @bctiemann

Base: main ← Head: 17542-Contact_Assignment_to_vpn_tunnels

📝 Commits (7)

  • 5b2241a fix(17542) add contact to tunnels
  • 113c8d1 Merge branch 'netbox-community:develop' into 17542-Contact_Assignment_to_vpn_tunnels
  • f83e55e Merge branch 'netbox-community:main' into 17542-Contact_Assignment_to_vpn_tunnels
  • 2a87285 fix(pep) fix pep8 compliancy
  • bda4f31 Merge branch 'netbox-community:main' into 17542-Contact_Assignment_to_vpn_tunnels
  • 59cd5bc fix double line breaks
  • a6c07e6 fix contact wrong model assignment

📊 Changes

2 files changed (+13 additions, -3 deletions)

View changed files

📝 netbox/vpn/models/tunnels.py (+3 -3)
📝 netbox/vpn/views.py (+10 -0)

📄 Description

Fixes: https://github.com/netbox-community/netbox/issues/17542

Add contacts to Tunnels and TunnelGroups

image

image

This is my first contribution, don't hesitate to give me feedback on what could be improved

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/18491 **Author:** [@antoinekh](https://github.com/antoinekh) **Created:** 1/25/2025 **Status:** ✅ Merged **Merged:** 2/25/2025 **Merged by:** [@bctiemann](https://github.com/bctiemann) **Base:** `main` ← **Head:** `17542-Contact_Assignment_to_vpn_tunnels` --- ### 📝 Commits (7) - [`5b2241a`](https://github.com/netbox-community/netbox/commit/5b2241aaaf8f52c3ba425233e8d8cb815197fbb8) fix(17542) add contact to tunnels - [`113c8d1`](https://github.com/netbox-community/netbox/commit/113c8d1d852edfa2be5c0190f048be00eecbb1ca) Merge branch 'netbox-community:develop' into 17542-Contact_Assignment_to_vpn_tunnels - [`f83e55e`](https://github.com/netbox-community/netbox/commit/f83e55e1db82a6f829dbe6e297fbc0af694e70cb) Merge branch 'netbox-community:main' into 17542-Contact_Assignment_to_vpn_tunnels - [`2a87285`](https://github.com/netbox-community/netbox/commit/2a8728544c7fd1d3399f51d7de87c14b46f8a2d5) fix(pep) fix pep8 compliancy - [`bda4f31`](https://github.com/netbox-community/netbox/commit/bda4f314a4ce251b7d344aa81f99b63fb70ad5cb) Merge branch 'netbox-community:main' into 17542-Contact_Assignment_to_vpn_tunnels - [`59cd5bc`](https://github.com/netbox-community/netbox/commit/59cd5bc653057d879e3b0dfd7553cdfcf85fa60d) fix double line breaks - [`a6c07e6`](https://github.com/netbox-community/netbox/commit/a6c07e6a35537da04e6eb9368d94d1901916afcf) fix contact wrong model assignment ### 📊 Changes **2 files changed** (+13 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `netbox/vpn/models/tunnels.py` (+3 -3) 📝 `netbox/vpn/views.py` (+10 -0) </details> ### 📄 Description **Fixes**: https://github.com/netbox-community/netbox/issues/17542 Add contacts to `Tunnels` and `TunnelGroups` ![image](https://github.com/user-attachments/assets/a562ddf8-1497-4514-a917-eb08506234c6) ![image](https://github.com/user-attachments/assets/faf2423f-3d6d-4b88-b639-28b3e234a251) This is my first contribution, don't hesitate to give me feedback on what could be improved --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 00:21:28 +01:00
adam closed this issue 2025-12-30 00:21:28 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#15359
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?