starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-13 13:53:31 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #18450] [MERGED] Fixes: #18447 - Fix sorting by mac_address field #15352

New Issue
Closed
opened 2025-12-30 00:21:26 +01:00 by adam · 0 comments
adam commented 2025-12-30 00:21:26 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/18450
Author: @DanSheps
Created: 1/21/2025
Status: ✅ Merged
Merged: 1/24/2025
Merged by: @bctiemann

Base: main ← Head: 18447-fix-legacy-macaddress-sorting

📝 Commits (3)

  • d191459 Fixes: #18447 - Fix sorting by mac_address field
  • ad4e4e8 Update VirtualMachineVMInterfaceTable
  • adcb6be Remove mac_address from tables.

📊 Changes

2 files changed (+8 additions, -8 deletions)

View changed files

📝 netbox/dcim/tables/devices.py (+1 -1)
📝 netbox/virtualization/tables/virtualmachines.py (+7 -7)

📄 Description

Fixes: #18447 - Fix sorting by mac_address field

  • Disable sorting by mac_address for legacy mac_address field for Device and VM Interfaces
  • Ensure primary_mac_address field is included in field list for Device and VM Interfaces

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/18450 **Author:** [@DanSheps](https://github.com/DanSheps) **Created:** 1/21/2025 **Status:** ✅ Merged **Merged:** 1/24/2025 **Merged by:** [@bctiemann](https://github.com/bctiemann) **Base:** `main` ← **Head:** `18447-fix-legacy-macaddress-sorting` --- ### 📝 Commits (3) - [`d191459`](https://github.com/netbox-community/netbox/commit/d1914595f6f30e8fa45e873ec1fa88998e8d89f0) Fixes: #18447 - Fix sorting by `mac_address` field - [`ad4e4e8`](https://github.com/netbox-community/netbox/commit/ad4e4e89a7a0124beaa5776ae8c4a459258d2336) Update `VirtualMachineVMInterfaceTable` - [`adcb6be`](https://github.com/netbox-community/netbox/commit/adcb6bebd2d5f35de33a698b4b765645aa0a0314) Remove `mac_address` from tables. ### 📊 Changes **2 files changed** (+8 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `netbox/dcim/tables/devices.py` (+1 -1) 📝 `netbox/virtualization/tables/virtualmachines.py` (+7 -7) </details> ### 📄 Description ### Fixes: #18447 - Fix sorting by `mac_address` field * Disable sorting by `mac_address` for legacy `mac_address` field for Device and VM Interfaces * Ensure `primary_mac_address` field is included in field list for Device and VM Interfaces --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 00:21:26 +01:00
adam closed this issue 2025-12-30 00:21:26 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#15352
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?