starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-14 06:13:32 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #18401] [MERGED] Fixes: #18400 - Migrate DEFAULT_FILE_STORAGE to STORAGES #15343

New Issue
Closed
opened 2025-12-30 00:21:23 +01:00 by adam · 0 comments
adam commented 2025-12-30 00:21:23 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/18401
Author: @bctiemann
Created: 1/15/2025
Status: ✅ Merged
Merged: 1/17/2025
Merged by: @jeremystretch

Base: main ← Head: 18400-django-STORAGES

📝 Commits (1)

  • 8fbb489 Migrate DEFAULT_FILE_STORAGE to STORAGES

📊 Changes

1 file changed (+11 additions, -1 deletions)

View changed files

📝 netbox/netbox/settings.py (+11 -1)

📄 Description

Fixes: #18400

Because DEFAULT_FILE_STORAGE has been deprecated in Django for a long time and is now no longer supported, the existing behavior of settings.py to set a custom STORAGE_BACKEND to that setting now no longer works. This change instead explicitly redeclares the default STORAGES and then overrides the default backend value with STORAGE_BACKEND.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/18401 **Author:** [@bctiemann](https://github.com/bctiemann) **Created:** 1/15/2025 **Status:** ✅ Merged **Merged:** 1/17/2025 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `main` ← **Head:** `18400-django-STORAGES` --- ### 📝 Commits (1) - [`8fbb489`](https://github.com/netbox-community/netbox/commit/8fbb489c42e17bf5db4b6a555557b185ff93a120) Migrate DEFAULT_FILE_STORAGE to STORAGES ### 📊 Changes **1 file changed** (+11 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `netbox/netbox/settings.py` (+11 -1) </details> ### 📄 Description ### Fixes: #18400 Because `DEFAULT_FILE_STORAGE` has been deprecated in Django for a long time and is now no longer supported, the existing behavior of `settings.py` to set a custom `STORAGE_BACKEND` to that setting now no longer works. This change instead explicitly redeclares the default `STORAGES` and then overrides the default backend value with `STORAGE_BACKEND`. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 00:21:23 +01:00
adam closed this issue 2025-12-30 00:21:24 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#15343
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?