starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-13 22:03:32 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #18388] [MERGED] Fixes: #18369 - Remove the json filter for protection rules #15338

New Issue
Closed
opened 2025-12-30 00:21:21 +01:00 by adam · 0 comments
adam commented 2025-12-30 00:21:21 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/18388
Author: @atownson
Created: 1/13/2025
Status: ✅ Merged
Merged: 1/17/2025
Merged by: @jeremystretch

Base: main ← Head: issue_18369

📝 Commits (3)

  • 3324d64 Remove the json filter for protection rules
  • f81b0a7 Configure PROTECTION_RULE config attribute to use ConfigJSONEncoder as serializer
  • 16d2e63 Tweak getattr()

📊 Changes

2 files changed (+4 additions, -3 deletions)

View changed files

📝 netbox/core/views.py (+3 -2)
📝 netbox/templates/core/inc/config_data.html (+1 -1)

📄 Description

Fixes: #18369

Removing the json filter resolves the TypeError exception and aligns the protection rules template with the custom validators template.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/18388 **Author:** [@atownson](https://github.com/atownson) **Created:** 1/13/2025 **Status:** ✅ Merged **Merged:** 1/17/2025 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `main` ← **Head:** `issue_18369` --- ### 📝 Commits (3) - [`3324d64`](https://github.com/netbox-community/netbox/commit/3324d64813304bad17fc30055525a90864c87392) Remove the json filter for protection rules - [`f81b0a7`](https://github.com/netbox-community/netbox/commit/f81b0a7dab987ce536ad35469a5075e4b9dc1468) Configure PROTECTION_RULE config attribute to use ConfigJSONEncoder as serializer - [`16d2e63`](https://github.com/netbox-community/netbox/commit/16d2e63dac4793cd1b216ffb6a24af69373d56bb) Tweak getattr() ### 📊 Changes **2 files changed** (+4 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `netbox/core/views.py` (+3 -2) 📝 `netbox/templates/core/inc/config_data.html` (+1 -1) </details> ### 📄 Description Fixes: #18369 Removing the json filter resolves the TypeError exception and aligns the protection rules template with the custom validators template. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 00:21:21 +01:00
adam closed this issue 2025-12-30 00:21:21 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#15338
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?