[PR #18371] [MERGED] Fixes: #18353 - Don't cache CACHE_KEY_CATALOG_ERROR if ISOLATED_DEPLOYMENT is True #15336

New Issue

adam · 2025-12-30T00:21:21+01:00

adam commented

2025-12-30 00:21:21 +01:00

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/18371
Author: @bctiemann
Created: 1/9/2025
Status: ✅ Merged
Merged: 1/9/2025
Merged by: @jeremystretch

Base: main ← Head: 18353-dont-cache-plugin-catalog-error-isolated

📝 Commits (1)

35a1f3c Don't cache CACHE_KEY_CATALOG_ERROR if ISOLATED_DEPLOYMENT is True

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 netbox/core/views.py (+1 -1)

📄 Description

Fixes: #18353

Skips caching the result of an errored call to get_catalog_plugins if ISOLATED_DEPLOYMENT == True. This call to the catalog API already has a short-circuit which returns {} and skips making the API call if ISOLATED_DEPLOYMENT is True; this change makes it so that the error popup does not appear and the errored result is not cached so that if the setting is turned off, the API call attempt will occur again right away.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/18371 **Author:** [@bctiemann](https://github.com/bctiemann) **Created:** 1/9/2025 **Status:** ✅ Merged **Merged:** 1/9/2025 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `main` ← **Head:** `18353-dont-cache-plugin-catalog-error-isolated` --- ### 📝 Commits (1) - [`35a1f3c`](https://github.com/netbox-community/netbox/commit/35a1f3c168424693b39d329c2f7b4900c6e510f8) Don't cache CACHE_KEY_CATALOG_ERROR if ISOLATED_DEPLOYMENT is True ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `netbox/core/views.py` (+1 -1) </details> ### 📄 Description ### Fixes: #18353 Skips caching the result of an errored call to `get_catalog_plugins` if `ISOLATED_DEPLOYMENT == True`. This call to the catalog API already has a short-circuit which returns `{}` and skips making the API call if `ISOLATED_DEPLOYMENT` is True; this change makes it so that the error popup does not appear and the errored result is not cached so that if the setting is turned off, the API call attempt will occur again right away. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-30 00:21:21 +01:00

adam closed this issue

2025-12-30 00:21:21 +01:00

Sign in to join this conversation.

Branches Tags

main

update-changelog-comments-docs

feature-removal-issue-type

20911-dropdown

20239-plugin-menu-classes-mutable-state

21097-graphql-id-lookups

feature

fix_module_substitution

20923-dcim-templates

20044-elevation-stuck-lightmode

feature-ip-prefix-link

v4.5-beta1-release

20068-import-moduletype-attrs

20766-fix-german-translation-code-literals

20378-del-script

7604-filter-modifiers-v3

circuit-swap

12318-case-insensitive-uniqueness

20637-improve-device-q-filter

20660-script-load

19724-graphql

20614-update-ruff

14884-script

02496-max-page

19720-macaddress-interface-generic-relation

19408-circuit-terminations-export-templates

20203-openapi-check

fix-19669-api-image-download

7604-filter-modifiers

19275-fixes-interface-bulk-edit

fix-17794-get_field_value_return_list

11507-show-aggregate-and-rir-on-api

9583-add_column_specific_search_field_to_tables

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/netbox#15336