starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #18361] [MERGED] Closes #18348: Disable legacy pre-commit hook script #15331

New Issue
Closed
opened 2025-12-30 00:21:19 +01:00 by adam · 0 comments
adam commented 2025-12-30 00:21:19 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/18361
Author: @jeremystretch
Created: 1/9/2025
Status: ✅ Merged
Merged: 1/13/2025
Merged by: @jeremystretch

Base: main ← Head: 18348-remove-precommit-hook

📝 Commits (1)

📊 Changes

1 file changed (+4 additions, -49 deletions)

View changed files

📝 scripts/git-hooks/pre-commit (+4 -49)

📄 Description

Closes: #18348

Force the legacy pre-commit git hook script to fail, forcing migration to the pre-commit tool.

I've opted to keep the script itself in place for now (rather than deleting it) to provide migration instructions for developers.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/18361 **Author:** [@jeremystretch](https://github.com/jeremystretch) **Created:** 1/9/2025 **Status:** ✅ Merged **Merged:** 1/13/2025 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `main` ← **Head:** `18348-remove-precommit-hook` --- ### 📝 Commits (1) - [`18c91c0`](https://github.com/netbox-community/netbox/commit/18c91c0f783f6b599050b045b1c5b776fa4cf7f3) Closes #18348: Disable legacy pre-commit hook script ### 📊 Changes **1 file changed** (+4 additions, -49 deletions) <details> <summary>View changed files</summary> 📝 `scripts/git-hooks/pre-commit` (+4 -49) </details> ### 📄 Description ### Closes: #18348 Force the legacy `pre-commit` git hook script to fail, forcing migration to the [pre-commit](https://pre-commit.com/) tool. I've opted to keep the script itself in place for now (rather than deleting it) to provide migration instructions for developers. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 00:21:19 +01:00
adam closed this issue 2025-12-30 00:21:19 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#15331
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?