[PR #18351] [MERGED] Fixes: #18350 - Remove 'site' and 'provider_network' from CircuitTerminationIndex.display_attrs #15329

New Issue

adam · 2025-12-30T00:21:18+01:00

adam commented

2025-12-30 00:21:18 +01:00

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/18351
Author: @bctiemann
Created: 1/8/2025
Status: ✅ Merged
Merged: 1/17/2025
Merged by: @jeremystretch

Base: main ← Head: 18350-remove-scoping-fields-on-CircuitTerminationIndex

📝 Commits (3)

2030e9f Remove 'site' and 'provider_network' from CircuitTerminationIndex.display_attrs
cafdfd7 Use '_site' and '_provider_network' in display_attrs
2911441 Replace private fields with 'termination'

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 netbox/circuits/search.py (+1 -1)

📄 Description

Fixes: #18350

As CircuitTermination has been refactored to move the fields site and provider_network to the new scoping model, this change uses the new internal (cached) versions of those fields in the displayed attributes in search results, resolving a crash condition.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/18351 **Author:** [@bctiemann](https://github.com/bctiemann) **Created:** 1/8/2025 **Status:** ✅ Merged **Merged:** 1/17/2025 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `main` ← **Head:** `18350-remove-scoping-fields-on-CircuitTerminationIndex` --- ### 📝 Commits (3) - [`2030e9f`](https://github.com/netbox-community/netbox/commit/2030e9fe3a38946674fa2245e641dd15d8f1cc2d) Remove 'site' and 'provider_network' from CircuitTerminationIndex.display_attrs - [`cafdfd7`](https://github.com/netbox-community/netbox/commit/cafdfd70f50104fd3913f79f8ca84b7ec9216223) Use '_site' and '_provider_network' in display_attrs - [`2911441`](https://github.com/netbox-community/netbox/commit/2911441cd1a73e44318db24fbf99530a66314197) Replace private fields with 'termination' ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `netbox/circuits/search.py` (+1 -1) </details> ### 📄 Description ### Fixes: #18350 As `CircuitTermination` has been refactored to move the fields `site` and `provider_network` to the new scoping model, this change uses the new internal (cached) versions of those fields in the displayed attributes in search results, resolving a crash condition. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-30 00:21:18 +01:00

adam closed this issue

2025-12-30 00:21:18 +01:00

Sign in to join this conversation.

Branches Tags

main

update-changelog-comments-docs

feature-removal-issue-type

20911-dropdown

20239-plugin-menu-classes-mutable-state

21097-graphql-id-lookups

feature

fix_module_substitution

20923-dcim-templates

20044-elevation-stuck-lightmode

feature-ip-prefix-link

v4.5-beta1-release

20068-import-moduletype-attrs

20766-fix-german-translation-code-literals

20378-del-script

7604-filter-modifiers-v3

circuit-swap

12318-case-insensitive-uniqueness

20637-improve-device-q-filter

20660-script-load

19724-graphql

20614-update-ruff

14884-script

02496-max-page

19720-macaddress-interface-generic-relation

19408-circuit-terminations-export-templates

20203-openapi-check

fix-19669-api-image-download

7604-filter-modifiers

19275-fixes-interface-bulk-edit

fix-17794-get_field_value_return_list

11507-show-aggregate-and-rir-on-api

9583-add_column_specific_search_field_to_tables

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/netbox#15329