[PR #18335] [MERGED] Fixes: #18282 - Change PrefixTable.vlan to represent the VLAN ID rather than the rich VLAN object #15326

Closed
opened 2025-12-30 00:21:17 +01:00 by adam · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/18335
Author: @bctiemann
Created: 1/7/2025
Status: Merged
Merged: 1/8/2025
Merged by: @jeremystretch

Base: mainHead: 18282-sort-prefixes-by-vlan-id


📝 Commits (2)

  • 6969c2c Change PrefixTable.vlan to represent the VLAN ID rather than the VLAN object, to enable more useful sorting by VLAN ID rather than site-grouped VLAN objects
  • 5e28e13 Use order_by to change ordering behavior of VLAN column rather than changing accessor

📊 Changes

1 file changed (+1 additions, -0 deletions)

View changed files

📝 netbox/ipam/tables/ip.py (+1 -0)

📄 Description

Fixes: #18282

Changes PrefixTable.vlan to represent the numeric vid field of VLAN to enable more meaningful sorting of the Prefixes table, rather than sorting by that column taking into account the many disparate Sites to which the VLAN objects belong.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/18335 **Author:** [@bctiemann](https://github.com/bctiemann) **Created:** 1/7/2025 **Status:** ✅ Merged **Merged:** 1/8/2025 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `main` ← **Head:** `18282-sort-prefixes-by-vlan-id` --- ### 📝 Commits (2) - [`6969c2c`](https://github.com/netbox-community/netbox/commit/6969c2cfe023fcb15d0d5797e98ca04ee94f1c9e) Change PrefixTable.vlan to represent the VLAN ID rather than the VLAN object, to enable more useful sorting by VLAN ID rather than site-grouped VLAN objects - [`5e28e13`](https://github.com/netbox-community/netbox/commit/5e28e131674a1c58d6eda8f5ae49fb9200dfa0e7) Use order_by to change ordering behavior of VLAN column rather than changing accessor ### 📊 Changes **1 file changed** (+1 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `netbox/ipam/tables/ip.py` (+1 -0) </details> ### 📄 Description ### Fixes: #18282 Changes `PrefixTable.vlan` to represent the numeric `vid` field of `VLAN` to enable more meaningful sorting of the Prefixes table, rather than sorting by that column taking into account the many disparate Sites to which the VLAN objects belong. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 00:21:17 +01:00
adam closed this issue 2025-12-30 00:21:17 +01:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#15326