starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #18291] [MERGED] Closes #18281: Support group assignment for virtual circuits #15311

New Issue
Closed
opened 2025-12-30 00:21:12 +01:00 by adam · 0 comments
adam commented 2025-12-30 00:21:12 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/18291
Author: @jeremystretch
Created: 1/2/2025
Status: ✅ Merged
Merged: 1/3/2025
Merged by: @jeremystretch

Base: feature ← Head: 18281-virtual-circuit-group

📝 Commits (7)

  • 73fa32c Rename circuit to member on CircuitGroupAssignment
  • 19b87e0 Support group assignment for virtual circuits
  • c31c430 Update release notes
  • ac68339 Introduce separate nav menu heading for circuit groups
  • 8b81522 Add generic relations for group assignments
  • 750e325 Remove obsolete code
  • 1d533c4 Clean up bulk import & extend tests

📊 Changes

21 files changed (+403 additions, -80 deletions)

View changed files

📝 docs/models/circuits/circuitgroupassignment.md (+2 -2)
📝 docs/release-notes/version-4.2.md (+3 -0)
📝 netbox/circuits/api/serializers_/circuits.py (+16 -5)
📝 netbox/circuits/constants.py (+8 -0)
📝 netbox/circuits/filtersets.py (+72 -20)
📝 netbox/circuits/forms/bulk_edit.py (+2 -2)
📝 netbox/circuits/forms/bulk_import.py (+10 -1)
📝 netbox/circuits/forms/filtersets.py (+2 -2)
📝 netbox/circuits/forms/model_forms.py (+44 -3)
📝 netbox/circuits/graphql/types.py (+8 -2)
➕ netbox/circuits/migrations/0051_virtualcircuit_group_assignment.py (+85 -0)
📝 netbox/circuits/models/circuits.py (+25 -12)
📝 netbox/circuits/models/virtual_circuits.py (+8 -0)
📝 netbox/circuits/tables/circuits.py (+8 -4)
📝 netbox/circuits/tests/test_api.py (+10 -7)
📝 netbox/circuits/tests/test_filtersets.py (+54 -12)
📝 netbox/circuits/tests/test_views.py (+20 -4)
📝 netbox/netbox/navigation/menu.py (+7 -2)
📝 netbox/templates/circuits/circuit.html (+1 -1)
📝 netbox/templates/circuits/circuitgroupassignment.html (+5 -1)

...and 1 more files

📄 Description

Closes: #18281

  • Convert the circuit ForeignKey on CircuitGroupAssignment to a generic foreign key (member)
  • Adapt Circuit & VirtualCircuit models for GFK-based group assignment
  • Rearrange navigation menu to list circuit groups separately

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/18291 **Author:** [@jeremystretch](https://github.com/jeremystretch) **Created:** 1/2/2025 **Status:** ✅ Merged **Merged:** 1/3/2025 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `feature` ← **Head:** `18281-virtual-circuit-group` --- ### 📝 Commits (7) - [`73fa32c`](https://github.com/netbox-community/netbox/commit/73fa32c01a74806acf7ff3538cb46f88838ee70a) Rename circuit to member on CircuitGroupAssignment - [`19b87e0`](https://github.com/netbox-community/netbox/commit/19b87e05b118d3982db7e35c6d5c4612bfc50714) Support group assignment for virtual circuits - [`c31c430`](https://github.com/netbox-community/netbox/commit/c31c4309999c06d340f6426f43e6298b70562f07) Update release notes - [`ac68339`](https://github.com/netbox-community/netbox/commit/ac68339e4f652b8ac82b244cf696741e24596f8d) Introduce separate nav menu heading for circuit groups - [`8b81522`](https://github.com/netbox-community/netbox/commit/8b815221642ee6bad8168a679fc9681d8ffac735) Add generic relations for group assignments - [`750e325`](https://github.com/netbox-community/netbox/commit/750e325a3612ccf2d1bfd8e97943ddc221772abf) Remove obsolete code - [`1d533c4`](https://github.com/netbox-community/netbox/commit/1d533c4e4a5ef9183f77a3b8f886dff4de8f5bef) Clean up bulk import & extend tests ### 📊 Changes **21 files changed** (+403 additions, -80 deletions) <details> <summary>View changed files</summary> 📝 `docs/models/circuits/circuitgroupassignment.md` (+2 -2) 📝 `docs/release-notes/version-4.2.md` (+3 -0) 📝 `netbox/circuits/api/serializers_/circuits.py` (+16 -5) 📝 `netbox/circuits/constants.py` (+8 -0) 📝 `netbox/circuits/filtersets.py` (+72 -20) 📝 `netbox/circuits/forms/bulk_edit.py` (+2 -2) 📝 `netbox/circuits/forms/bulk_import.py` (+10 -1) 📝 `netbox/circuits/forms/filtersets.py` (+2 -2) 📝 `netbox/circuits/forms/model_forms.py` (+44 -3) 📝 `netbox/circuits/graphql/types.py` (+8 -2) ➕ `netbox/circuits/migrations/0051_virtualcircuit_group_assignment.py` (+85 -0) 📝 `netbox/circuits/models/circuits.py` (+25 -12) 📝 `netbox/circuits/models/virtual_circuits.py` (+8 -0) 📝 `netbox/circuits/tables/circuits.py` (+8 -4) 📝 `netbox/circuits/tests/test_api.py` (+10 -7) 📝 `netbox/circuits/tests/test_filtersets.py` (+54 -12) 📝 `netbox/circuits/tests/test_views.py` (+20 -4) 📝 `netbox/netbox/navigation/menu.py` (+7 -2) 📝 `netbox/templates/circuits/circuit.html` (+1 -1) 📝 `netbox/templates/circuits/circuitgroupassignment.html` (+5 -1) _...and 1 more files_ </details> ### 📄 Description ### Closes: #18281 - Convert the `circuit` ForeignKey on CircuitGroupAssignment to a generic foreign key (`member`) - Adapt Circuit & VirtualCircuit models for GFK-based group assignment - Rearrange navigation menu to list circuit groups separately --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 00:21:12 +01:00
adam closed this issue 2025-12-30 00:21:12 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#15311
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?