starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-14 14:23:32 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #18200] [MERGED] Closes #18045: Enable adding a new MAC to an interface via quick add #15287

New Issue
Closed
opened 2025-12-30 00:21:04 +01:00 by adam · 0 comments
adam commented 2025-12-30 00:21:04 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/18200
Author: @jeremystretch
Created: 12/10/2024
Status: ✅ Merged
Merged: 12/16/2024
Merged by: @jeremystretch

Base: feature ← Head: 18045-mac-address-quick-add

📝 Commits (2)

📊 Changes

6 files changed (+46 additions, -17 deletions)

View changed files

📝 netbox/dcim/forms/common.py (+0 -8)
📝 netbox/dcim/forms/model_forms.py (+7 -0)
📝 netbox/utilities/forms/fields/dynamic.py (+20 -6)
📝 netbox/utilities/forms/widgets/apiselect.py (+9 -0)
📝 netbox/utilities/templates/widgets/apiselect.html (+2 -2)
📝 netbox/virtualization/forms/model_forms.py (+8 -1)

📄 Description

Fixes: #18045

  • Move the primary_mac_address field from InterfaceCommonForm to the device & VM interface forms
  • Introduce the quick_add_params keyword argument on DynamicModelChoiceMixin
  • Alter APISelect to set quick-add parameters on the widget (rather than passing as widget attrs) & expose them as template context

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/18200 **Author:** [@jeremystretch](https://github.com/jeremystretch) **Created:** 12/10/2024 **Status:** ✅ Merged **Merged:** 12/16/2024 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `feature` ← **Head:** `18045-mac-address-quick-add` --- ### 📝 Commits (2) - [`790aed2`](https://github.com/netbox-community/netbox/commit/790aed268882baaf8ff06242a475177da06de2cb) Closes #18045: Enable adding a new MAC to an interface via quick add - [`8bf7e90`](https://github.com/netbox-community/netbox/commit/8bf7e90bc27f264ccfb34e487f9af96a481aa1c9) Misc cleanup ### 📊 Changes **6 files changed** (+46 additions, -17 deletions) <details> <summary>View changed files</summary> 📝 `netbox/dcim/forms/common.py` (+0 -8) 📝 `netbox/dcim/forms/model_forms.py` (+7 -0) 📝 `netbox/utilities/forms/fields/dynamic.py` (+20 -6) 📝 `netbox/utilities/forms/widgets/apiselect.py` (+9 -0) 📝 `netbox/utilities/templates/widgets/apiselect.html` (+2 -2) 📝 `netbox/virtualization/forms/model_forms.py` (+8 -1) </details> ### 📄 Description ### Fixes: #18045 - Move the `primary_mac_address` field from InterfaceCommonForm to the device & VM interface forms - Introduce the `quick_add_params` keyword argument on DynamicModelChoiceMixin - Alter APISelect to set quick-add parameters on the widget (rather than passing as widget attrs) & expose them as template context --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 00:21:04 +01:00
adam closed this issue 2025-12-30 00:21:05 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#15287
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?