starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #18186] [MERGED] Fixes: #18184 - Gracefully handle unavailable internet connection on RSS feed dashboard widget if ISOLATED_DEPLOYMENT is set #15285

New Issue
Closed
opened 2025-12-30 00:21:04 +01:00 by adam · 0 comments
adam commented 2025-12-30 00:21:04 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/18186
Author: @bctiemann
Created: 12/10/2024
Status: ✅ Merged
Merged: 12/16/2024
Merged by: @jeremystretch

Base: feature ← Head: 18184-suppress-rss-feed-for-isolated-deployment

📝 Commits (4)

  • 01d9f10 Suppress adding the RSS feed widget to the dashboard if ISOLATED_DEPLOYMENT is set
  • 43bfee9 Add config option on RSSFeedWidget to specify requires_internet and to display a more appropriate error if ISOLATED_DEPLOYMENT is set
  • 3dda600 Remove skipping behavior from utils.py
  • d2dede2 Add required=False

📊 Changes

3 files changed (+15 additions, -0 deletions)

View changed files

📝 netbox/extras/constants.py (+1 -0)
📝 netbox/extras/dashboard/widgets.py (+10 -0)
📝 netbox/templates/extras/dashboard/widgets/rssfeed.html (+4 -0)

📄 Description

Fixes: #18184

Because the RSS feed widget ("NetBox News") will return an error in an isolated deployment, this change skips adding that widget to the default dashboard if ISOLATED_DEPLOYMENT is set in the configuration.

Note that this matches all extras.RSSFeedWidget type widgets, so any additional RSS feeds we add to DEFAULT_DASHBOARD in the future will also be skipped in this situation.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/18186 **Author:** [@bctiemann](https://github.com/bctiemann) **Created:** 12/10/2024 **Status:** ✅ Merged **Merged:** 12/16/2024 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `feature` ← **Head:** `18184-suppress-rss-feed-for-isolated-deployment` --- ### 📝 Commits (4) - [`01d9f10`](https://github.com/netbox-community/netbox/commit/01d9f101dd52c2afc1f75c08bfca18159da145f7) Suppress adding the RSS feed widget to the dashboard if ISOLATED_DEPLOYMENT is set - [`43bfee9`](https://github.com/netbox-community/netbox/commit/43bfee94f011bbafb14aafee4e0d701acd8d7353) Add config option on RSSFeedWidget to specify requires_internet and to display a more appropriate error if ISOLATED_DEPLOYMENT is set - [`3dda600`](https://github.com/netbox-community/netbox/commit/3dda60099978a0ddb86c7fc30390a3eba0221a0a) Remove skipping behavior from utils.py - [`d2dede2`](https://github.com/netbox-community/netbox/commit/d2dede249d5df4f1e11dfeefd24a3fa56e8f86f3) Add required=False ### 📊 Changes **3 files changed** (+15 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `netbox/extras/constants.py` (+1 -0) 📝 `netbox/extras/dashboard/widgets.py` (+10 -0) 📝 `netbox/templates/extras/dashboard/widgets/rssfeed.html` (+4 -0) </details> ### 📄 Description ### Fixes: #18184 Because the RSS feed widget ("NetBox News") will return an error in an isolated deployment, this change skips adding that widget to the default dashboard if `ISOLATED_DEPLOYMENT` is set in the configuration. Note that this matches all `extras.RSSFeedWidget` type widgets, so any additional RSS feeds we add to `DEFAULT_DASHBOARD` in the future will also be skipped in this situation. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 00:21:04 +01:00
adam closed this issue 2025-12-30 00:21:04 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#15285
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?