[PR #18185] [MERGED] Fixes 18183 - Hide Light/Dark Mode and Login Info from Printed Pages #15284

Closed
opened 2025-12-30 00:21:03 +01:00 by adam · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/18185
Author: @jchambers2012
Created: 12/9/2024
Status: Merged
Merged: 12/10/2024
Merged by: @jeremystretch

Base: developHead: 18183-fixes-print-view


📝 Commits (2)

  • 4586332 Fixes Print Render
  • 20ca33b Suppress the mobile view when printing

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 netbox/templates/base/layout.html (+1 -1)

📄 Description

Fixes: #18183

This will add the d-print-none to the mobile view so objects being printed out will suppress the Light/Dark Mode and Login Info. Looking at the template, it was intended to suppress these details, but Chrome and Firefox are triggering in the mobile view for printing. I tested on both Chrome (131.0.6778.109 (Official Build) (64-bit)) and Firefox (128.5.1esr (64-bit)).

Pre-Change:

393964173-19d8d757-40dd-406a-9424-63ec6b464072

Post Change:

393964481-8cfff0cc-e9b0-4bf2-87d0-f3c11009df9c


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/18185 **Author:** [@jchambers2012](https://github.com/jchambers2012) **Created:** 12/9/2024 **Status:** ✅ Merged **Merged:** 12/10/2024 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop` ← **Head:** `18183-fixes-print-view` --- ### 📝 Commits (2) - [`4586332`](https://github.com/netbox-community/netbox/commit/458633275aab0a6500d522afd07365d5b8447ed4) Fixes Print Render - [`20ca33b`](https://github.com/netbox-community/netbox/commit/20ca33b1600e2381dc170e5026a7ecf1606342e1) Suppress the mobile view when printing ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `netbox/templates/base/layout.html` (+1 -1) </details> ### 📄 Description ### Fixes: #18183 This will add the `d-print-none` to the mobile view so objects being printed out will suppress the Light/Dark Mode and Login Info. Looking at the template, it was intended to suppress these details, but Chrome and Firefox are triggering in the mobile view for printing. I tested on both Chrome (131.0.6778.109 (Official Build) (64-bit)) and Firefox (128.5.1esr (64-bit)). ### Pre-Change: ![393964173-19d8d757-40dd-406a-9424-63ec6b464072](https://github.com/user-attachments/assets/8fe9d144-9a2b-47c9-b7ca-9f22ebbb1ce1) ### Post Change: ![393964481-8cfff0cc-e9b0-4bf2-87d0-f3c11009df9c](https://github.com/user-attachments/assets/f5f1a535-df09-4d59-bdf3-05ef0b1b8f89) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 00:21:03 +01:00
adam closed this issue 2025-12-30 00:21:03 +01:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#15284