[PR #18135] [CLOSED] Fixes: #18032 - Clear ordering preferences if set to a nonexistent field #15279

New Issue

adam · 2025-12-30T00:21:02+01:00

adam commented

2025-12-30 00:21:02 +01:00

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/18135
Author: @bctiemann
Created: 12/2/2024
Status: ❌ Closed

Base: develop ← Head: 18032-clear-stale-ordering-column-on-fielderror

📝 Commits (1)

93821ca Clear ordering preferences if set to a nonexistent field (i.e. if upgrading to a version with changed fields)

📊 Changes

1 file changed (+6 additions, -2 deletions)

View changed files

📝 netbox/netbox/tables/tables.py (+6 -2)

📄 Description

Fixes: #18032

It is possible to have a user preference set to a field which no longer exists in a new version of NetBox after an upgrade. Normally django-tables2 validates all sort=<column> query params against the table's columns and filters out any invalid values prior to storage as a preference; but if a sort value that was previously (but is no longer) valid has been stored in the preferences, a FieldError will be raised under the new version.

This change catches that FieldError and clears the preference accordingly.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/18135 **Author:** [@bctiemann](https://github.com/bctiemann) **Created:** 12/2/2024 **Status:** ❌ Closed **Base:** `develop` ← **Head:** `18032-clear-stale-ordering-column-on-fielderror` --- ### 📝 Commits (1) - [`93821ca`](https://github.com/netbox-community/netbox/commit/93821ca0eaa4cd6f7af36676bcf58b81903cd156) Clear ordering preferences if set to a nonexistent field (i.e. if upgrading to a version with changed fields) ### 📊 Changes **1 file changed** (+6 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `netbox/netbox/tables/tables.py` (+6 -2) </details> ### 📄 Description ### Fixes: #18032 It is possible to have a user preference set to a field which no longer exists in a new version of NetBox after an upgrade. Normally django-tables2 validates all `sort=<column>` query params against the table's `columns` and filters out any invalid values prior to storage as a preference; but if a `sort` value that was previously (but is no longer) valid has been stored in the preferences, a `FieldError` will be raised under the new version. This change catches that `FieldError` and clears the preference accordingly. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-30 00:21:02 +01:00

adam closed this issue

2025-12-30 00:21:02 +01:00

Sign in to join this conversation.

Branches Tags

main

21142-device-component-graphql-filters

21050-device-oob-ip-may-become-orphaned

21102-fix-graphiql-explorer

20911-dropdown

20239-plugin-menu-classes-mutable-state

21097-graphql-id-lookups

feature

fix_module_substitution

20923-dcim-templates

20044-elevation-stuck-lightmode

feature-ip-prefix-link

v4.5-beta1-release

20068-import-moduletype-attrs

20766-fix-german-translation-code-literals

20378-del-script

7604-filter-modifiers-v3

circuit-swap

12318-case-insensitive-uniqueness

20637-improve-device-q-filter

20660-script-load

19724-graphql

20614-update-ruff

14884-script

02496-max-page

19720-macaddress-interface-generic-relation

19408-circuit-terminations-export-templates

20203-openapi-check

fix-19669-api-image-download

7604-filter-modifiers

19275-fixes-interface-bulk-edit

fix-17794-get_field_value_return_list

11507-show-aggregate-and-rir-on-api

9583-add_column_specific_search_field_to_tables

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/netbox#15279