[PR #18106] [MERGED] Fixes #17490: Config Template unable to dynamically include templates #15274

New Issue

adam · 2025-12-30T00:21:00+01:00

adam commented

2025-12-30 00:21:00 +01:00

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/18106
Author: @robduffy2010
Created: 11/26/2024
Status: ✅ Merged
Merged: 12/5/2024
Merged by: @jeremystretch

Base: develop ← Head: 17490-fix-dynamically-including-templates

📝 Commits (4)

9f45300 Fixes #17490: Config Template unable to dynamically include templates
9930fef Cast the generator returned by find_referenced_templates() to an iterable to avoid exhausting it on the check for None
5173a49 Apply the path__in filter to avoid duplicating code
20c0235 Remove extra if None not in referenced_templates

📊 Changes

1 file changed (+7 additions, -3 deletions)

View changed files

📝 netbox/utilities/jinja2.py (+7 -3)

📄 Description

Fixes: #17490

Config templates are unable to dynamically include child templates. This is a proposed fix as suggested by @ed-ud in #18066 which was closed as a duplicate.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/18106 **Author:** [@robduffy2010](https://github.com/robduffy2010) **Created:** 11/26/2024 **Status:** ✅ Merged **Merged:** 12/5/2024 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop` ← **Head:** `17490-fix-dynamically-including-templates` --- ### 📝 Commits (4) - [`9f45300`](https://github.com/netbox-community/netbox/commit/9f453009999922a4589c6289cd61866acf74afcb) Fixes #17490: Config Template unable to dynamically include templates - [`9930fef`](https://github.com/netbox-community/netbox/commit/9930fef28b152d431544998847a2b4a1d23e9d9a) Cast the generator returned by find_referenced_templates() to an iterable to avoid exhausting it on the check for None - [`5173a49`](https://github.com/netbox-community/netbox/commit/5173a490b827ccf12b117acbf44f9cd7beda2c63) Apply the path__in filter to avoid duplicating code - [`20c0235`](https://github.com/netbox-community/netbox/commit/20c02350065712e7fe75904a3a6697884abbb670) Remove extra if None not in referenced_templates ### 📊 Changes **1 file changed** (+7 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `netbox/utilities/jinja2.py` (+7 -3) </details> ### 📄 Description ### Fixes: #17490 Config templates are unable to dynamically include child templates. This is a proposed fix as suggested by @ed-ud in #18066 which was closed as a duplicate. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-30 00:21:00 +01:00

adam closed this issue

2025-12-30 00:21:01 +01:00

Sign in to join this conversation.

Branches Tags

main

21050-device-oob-ip-may-become-orphaned

21102-fix-graphiql-explorer

20911-dropdown

20239-plugin-menu-classes-mutable-state

21097-graphql-id-lookups

feature

fix_module_substitution

20923-dcim-templates

20044-elevation-stuck-lightmode

feature-ip-prefix-link

v4.5-beta1-release

20068-import-moduletype-attrs

20766-fix-german-translation-code-literals

20378-del-script

7604-filter-modifiers-v3

circuit-swap

12318-case-insensitive-uniqueness

20637-improve-device-q-filter

20660-script-load

19724-graphql

20614-update-ruff

14884-script

02496-max-page

19720-macaddress-interface-generic-relation

19408-circuit-terminations-export-templates

20203-openapi-check

fix-19669-api-image-download

7604-filter-modifiers

19275-fixes-interface-bulk-edit

fix-17794-get_field_value_return_list

11507-show-aggregate-and-rir-on-api

9583-add_column_specific_search_field_to_tables

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/netbox#15274