starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-14 06:13:32 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #18084] [MERGED] Fixes: #17820 - Store default values from custom fields on newly created module components #15269

New Issue
Closed
opened 2025-12-30 00:20:59 +01:00 by adam · 0 comments
adam commented 2025-12-30 00:20:59 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/18084
Author: @bctiemann
Created: 11/25/2024
Status: ✅ Merged
Merged: 12/11/2024
Merged by: @jeremystretch

Base: develop ← Head: 17820-save-custom-field-default-values-on-module-component

📝 Commits (2)

  • ca13500 Store default values from custom fields on newly created module components
  • 4ddfa43 Invert if/for lines to avoid repetition

📊 Changes

1 file changed (+5 additions, -0 deletions)

View changed files

📝 netbox/dcim/models/devices.py (+5 -0)

📄 Description

Fixes: #17820

Fixes a piece of missing functionality in the Module.save() method where custom field default values are not applied during creation of new module-templated components.

Does not apply to update operations, only create.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/18084 **Author:** [@bctiemann](https://github.com/bctiemann) **Created:** 11/25/2024 **Status:** ✅ Merged **Merged:** 12/11/2024 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop` ← **Head:** `17820-save-custom-field-default-values-on-module-component` --- ### 📝 Commits (2) - [`ca13500`](https://github.com/netbox-community/netbox/commit/ca1350062202e1fdfcacf72a2822733caca8318f) Store default values from custom fields on newly created module components - [`4ddfa43`](https://github.com/netbox-community/netbox/commit/4ddfa436b49735c2597df8b79c121631240c876a) Invert if/for lines to avoid repetition ### 📊 Changes **1 file changed** (+5 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `netbox/dcim/models/devices.py` (+5 -0) </details> ### 📄 Description ### Fixes: #17820 Fixes a piece of missing functionality in the `Module.save()` method where custom field default values are not applied during creation of new module-templated components. Does not apply to update operations, only create. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 00:20:59 +01:00
adam closed this issue 2025-12-30 00:20:59 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#15269
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?