starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-14 06:13:32 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #18041] [MERGED] Fixes: #18037 - Bound VLANGroup VLAN ID max by VLAN_VID_MAX #15257

New Issue
Closed
opened 2025-12-30 00:20:55 +01:00 by adam · 0 comments
adam commented 2025-12-30 00:20:55 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/18041
Author: @DanSheps
Created: 11/19/2024
Status: ✅ Merged
Merged: 11/20/2024
Merged by: @jeremystretch

Base: develop ← Head: 18037-fix-invalid-vlan-range

📝 Commits (4)

  • 4e2c7c2 Fixes: #18037 - Bound VLANGroup VLAN ID max by VLAN_VID_MAX
  • d1db380 Correct exception string
  • c5d8715 Validate min & max VID values
  • 9d2978d Fix min/max VID validation

📊 Changes

1 file changed (+21 additions, -5 deletions)

View changed files

📝 netbox/ipam/models/vlans.py (+21 -5)

📄 Description

Fixes: #18037 - Restrict VLANGroup VID max to 4094

  • Bound VLANGroup VLAN ID max by VLAN_VID_MAX

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/18041 **Author:** [@DanSheps](https://github.com/DanSheps) **Created:** 11/19/2024 **Status:** ✅ Merged **Merged:** 11/20/2024 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop` ← **Head:** `18037-fix-invalid-vlan-range` --- ### 📝 Commits (4) - [`4e2c7c2`](https://github.com/netbox-community/netbox/commit/4e2c7c2e2ed88fa468ada1a1acc11e5f1a729f48) Fixes: #18037 - Bound VLANGroup VLAN ID max by `VLAN_VID_MAX` - [`d1db380`](https://github.com/netbox-community/netbox/commit/d1db3807aaae611671663026c2f50e1462caaf8f) Correct exception string - [`c5d8715`](https://github.com/netbox-community/netbox/commit/c5d87152a5b7483ee7e5f2e950dcc5badb8d9e40) Validate min & max VID values - [`9d2978d`](https://github.com/netbox-community/netbox/commit/9d2978d9efaeaa74cba54f349db71e9fc4d0bcc4) Fix min/max VID validation ### 📊 Changes **1 file changed** (+21 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `netbox/ipam/models/vlans.py` (+21 -5) </details> ### 📄 Description ### Fixes: #18037 - Restrict VLANGroup VID max to 4094 * Bound VLANGroup VLAN ID max by `VLAN_VID_MAX` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 00:20:55 +01:00
adam closed this issue 2025-12-30 00:20:55 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#15257
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?