starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-13 22:03:32 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #17978] [CLOSED] Remove redundant check for 'vminterface' in assigned_object_parent #15240

New Issue
Closed
opened 2025-12-30 00:20:48 +01:00 by adam · 0 comments
adam commented 2025-12-30 00:20:48 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/17978
Author: @Kani999
Created: 11/11/2024
Status: ❌ Closed

Base: develop ← Head: patch-1

📝 Commits (1)

  • e451300 Remove redundant check for 'vminterface' in assigned_object_parent

📊 Changes

1 file changed (+0 additions, -2 deletions)

View changed files

📝 netbox/vpn/models/l2vpn.py (+0 -2)

📄 Description

Description

This pull request removes a redundant check for the 'vminterface' model in the assigned_object_parent property of the L2VPNTermination class.

Changes

  • Removed the redundant elif obj_type.model == 'vminterface': statement

Impact

This change simplifies the assigned_object_parent property by eliminating unnecessary code, ensuring that the logic is clear and maintainable.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/17978 **Author:** [@Kani999](https://github.com/Kani999) **Created:** 11/11/2024 **Status:** ❌ Closed **Base:** `develop` ← **Head:** `patch-1` --- ### 📝 Commits (1) - [`e451300`](https://github.com/netbox-community/netbox/commit/e45130066b8cdacfaed59433c118c02be23f211b) Remove redundant check for 'vminterface' in assigned_object_parent ### 📊 Changes **1 file changed** (+0 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `netbox/vpn/models/l2vpn.py` (+0 -2) </details> ### 📄 Description ## Description This pull request removes a redundant check for the 'vminterface' model in the assigned_object_parent property of the L2VPNTermination class. ## Changes - Removed the redundant `elif obj_type.model == 'vminterface':` statement ## Impact This change simplifies the assigned_object_parent property by eliminating unnecessary code, ensuring that the logic is clear and maintainable. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 00:20:48 +01:00
adam closed this issue 2025-12-30 00:20:48 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#15240
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?