starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-14 06:13:32 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #17952] [MERGED] Closes #17951: Extend Ruff ruleset #15235

New Issue
Closed
opened 2025-12-30 00:20:47 +01:00 by adam · 0 comments
adam commented 2025-12-30 00:20:47 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/17952
Author: @jeremystretch
Created: 11/7/2024
Status: ✅ Merged
Merged: 11/7/2024
Merged by: @jeremystretch

Base: feature ← Head: 17951-add-ruff-rules

📝 Commits (1)

📊 Changes

16 files changed (+29 additions, -29 deletions)

View changed files

📝 netbox/circuits/migrations/0047_circuittermination__termination.py (+1 -0)
📝 netbox/circuits/tests/test_views.py (+1 -1)
📝 netbox/extras/forms/bulk_import.py (+1 -1)
📝 netbox/extras/management/commands/runscript.py (+1 -1)
📝 netbox/extras/migrations/0109_script_model.py (+2 -2)
📝 netbox/ipam/lookups.py (+2 -2)
📝 netbox/ipam/tests/test_ordering.py (+3 -3)
📝 netbox/netbox/authentication/__init__.py (+1 -1)
📝 netbox/netbox/tests/test_plugins.py (+0 -1)
📝 netbox/netbox/views/errors.py (+1 -1)
📝 netbox/utilities/error_handlers.py (+1 -1)
📝 netbox/utilities/tests/test_counters.py (+1 -1)
📝 netbox/virtualization/api/serializers_/clusters.py (+0 -2)
📝 netbox/virtualization/graphql/types.py (+1 -1)
📝 netbox/virtualization/migrations/0044_cluster_scope.py (+11 -11)
📝 ruff.toml (+2 -0)

📄 Description

Fixes: #17951

  • Enables Ruff preview mode
  • Enables E1, E2, E3, and W rules

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/17952 **Author:** [@jeremystretch](https://github.com/jeremystretch) **Created:** 11/7/2024 **Status:** ✅ Merged **Merged:** 11/7/2024 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `feature` ← **Head:** `17951-add-ruff-rules` --- ### 📝 Commits (1) - [`2e2b7da`](https://github.com/netbox-community/netbox/commit/2e2b7dad72bed7694fe9d29117f7fdb67f5f7438) Closes #17951: Extend Ruff ruleset ### 📊 Changes **16 files changed** (+29 additions, -29 deletions) <details> <summary>View changed files</summary> 📝 `netbox/circuits/migrations/0047_circuittermination__termination.py` (+1 -0) 📝 `netbox/circuits/tests/test_views.py` (+1 -1) 📝 `netbox/extras/forms/bulk_import.py` (+1 -1) 📝 `netbox/extras/management/commands/runscript.py` (+1 -1) 📝 `netbox/extras/migrations/0109_script_model.py` (+2 -2) 📝 `netbox/ipam/lookups.py` (+2 -2) 📝 `netbox/ipam/tests/test_ordering.py` (+3 -3) 📝 `netbox/netbox/authentication/__init__.py` (+1 -1) 📝 `netbox/netbox/tests/test_plugins.py` (+0 -1) 📝 `netbox/netbox/views/errors.py` (+1 -1) 📝 `netbox/utilities/error_handlers.py` (+1 -1) 📝 `netbox/utilities/tests/test_counters.py` (+1 -1) 📝 `netbox/virtualization/api/serializers_/clusters.py` (+0 -2) 📝 `netbox/virtualization/graphql/types.py` (+1 -1) 📝 `netbox/virtualization/migrations/0044_cluster_scope.py` (+11 -11) 📝 `ruff.toml` (+2 -0) </details> ### 📄 Description ### Fixes: #17951 - Enables Ruff preview mode - Enables E1, E2, E3, and W rules --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 00:20:47 +01:00
adam closed this issue 2025-12-30 00:20:47 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#15235
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?