starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #17931] [MERGED] Fixes: #17459 - Ensure help text on component create forms shows both bulk edit and substitution token instructions #15233

New Issue
Closed
opened 2025-12-30 00:20:46 +01:00 by adam · 0 comments
adam commented 2025-12-30 00:20:46 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/17931
Author: @bctiemann
Created: 11/4/2024
Status: ✅ Merged
Merged: 11/21/2024
Merged by: @jeremystretch

Base: develop ← Head: 17459-fix-component-help-text

📝 Commits (7)

  • ba7dbcf Move {module} substitution help text to main ComponentCreateForm.init so it applies to all component types, and fix formatting
  • d6bde32 Simplify help text replacement string for component forms with 'module' field
  • 37b5413 Reuse help text string in both ComponentCreateForm and ModularComponentTemplateForm
  • 1fb79c2 Merge branch 'develop' into 17459-fix-component-help-text
  • d0b7135 Remove help text override from regular (direct) object creation of device components
  • 663b7f8 Re-add space
  • 8ee1440 Tweak help text

📊 Changes

2 files changed (+7 additions, -8 deletions)

View changed files

📝 netbox/dcim/forms/model_forms.py (+7 -0)
📝 netbox/dcim/forms/object_create.py (+0 -8)

📄 Description

Fixes: #17459

This PR does two things:

  1. Ensures that the The string <code>{module}</code> will be replaced with the position of the assigned module, if any. string is shown on the name field of modular component template create forms, in addition to the Alphanumeric ranges are supported for bulk creation string, instead of the latter overwriting the former

  2. Moves the {module} help_text logic from InterfaceCreateForm to the generic ComponentCreateForm so that it applies to all modular device components which share the same bulk creation logic

Screenshot 2024-11-04 at 3 54 53 PM

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/17931 **Author:** [@bctiemann](https://github.com/bctiemann) **Created:** 11/4/2024 **Status:** ✅ Merged **Merged:** 11/21/2024 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop` ← **Head:** `17459-fix-component-help-text` --- ### 📝 Commits (7) - [`ba7dbcf`](https://github.com/netbox-community/netbox/commit/ba7dbcfc4f79e2be24062133120331ae26a8abb7) Move {module} substitution help text to main ComponentCreateForm.__init__ so it applies to all component types, and fix formatting - [`d6bde32`](https://github.com/netbox-community/netbox/commit/d6bde32056f94e8c97b2a50caece6a507b737146) Simplify help text replacement string for component forms with 'module' field - [`37b5413`](https://github.com/netbox-community/netbox/commit/37b5413e45f45168ce31ed57bb93a4b2cb62921a) Reuse help text string in both ComponentCreateForm and ModularComponentTemplateForm - [`1fb79c2`](https://github.com/netbox-community/netbox/commit/1fb79c24e7ded56ae5b682e5fe68ff3f0d5a9d67) Merge branch 'develop' into 17459-fix-component-help-text - [`d0b7135`](https://github.com/netbox-community/netbox/commit/d0b7135dd8102415bae05a55348ec60c2f9a8844) Remove help text override from regular (direct) object creation of device components - [`663b7f8`](https://github.com/netbox-community/netbox/commit/663b7f89018098c30e3c8816a5d0bec43262f069) Re-add space - [`8ee1440`](https://github.com/netbox-community/netbox/commit/8ee14409c2f8039c3cb1bebfe940870dabf7e4c3) Tweak help text ### 📊 Changes **2 files changed** (+7 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `netbox/dcim/forms/model_forms.py` (+7 -0) 📝 `netbox/dcim/forms/object_create.py` (+0 -8) </details> ### 📄 Description ### Fixes: #17459 This PR does two things: 1. Ensures that the `The string <code>{module}</code> will be replaced with the position of the assigned module, if any.` string is shown on the `name` field of modular component template create forms, in addition to the `Alphanumeric ranges are supported for bulk creation` string, instead of the latter overwriting the former 2. Moves the `{module}` help_text logic from `InterfaceCreateForm` to the generic `ComponentCreateForm` so that it applies to all modular device components which share the same bulk creation logic <img width="838" alt="Screenshot 2024-11-04 at 3 54 53 PM" src="https://github.com/user-attachments/assets/bf150921-fb49-4368-a59a-6c5cd84b41d7"> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 00:20:46 +01:00
adam closed this issue 2025-12-30 00:20:46 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#15233
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?