starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #17930] [MERGED] 17929 Add Scope Mixins to Prefix #15230

New Issue
Closed
opened 2025-12-30 00:20:44 +01:00 by adam · 0 comments
adam commented 2025-12-30 00:20:44 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/17930
Author: @arthanson
Created: 11/4/2024
Status: ✅ Merged
Merged: 11/15/2024
Merged by: @jeremystretch

Base: feature ← Head: 17929-prefix-scope

📝 Commits (10+)

  • 5189b1d 17929 Add Scope Mixins to Prefix
  • 8f8376f 17929 Add Scope Mixins to Prefix
  • 4a0f2e9 17929 fixes for tests
  • ee274c8 Merge branch 'feature' into 17929-prefix-scope
  • 287a647 17929 merge latest scope changes
  • 805954e Merge branch 'feature' into 17929-prefix-scope
  • 2d367ee 12596 review changes
  • 19384f8 12596 review changes
  • 0e29f54 12596 review changes
  • cd3b376 12596 review changes

📊 Changes

22 files changed (+187 additions, -290 deletions)

View changed files

📝 netbox/dcim/api/serializers_/sites.py (+4 -4)
➕ netbox/dcim/base_filtersets.py (+67 -0)
📝 netbox/dcim/filtersets.py (+0 -58)
📝 netbox/dcim/graphql/types.py (+4 -4)
📝 netbox/dcim/models/mixins.py (+0 -4)
📝 netbox/ipam/api/serializers_/ip.py (+3 -2)
📝 netbox/ipam/apps.py (+1 -1)
📝 netbox/ipam/constants.py (+0 -5)
📝 netbox/ipam/filtersets.py (+3 -53)
📝 netbox/ipam/forms/bulk_edit.py (+2 -28)
📝 netbox/ipam/forms/bulk_import.py (+3 -7)
📝 netbox/ipam/forms/model_forms.py (+2 -44)
📝 netbox/ipam/graphql/types.py (+1 -1)
📝 netbox/ipam/migrations/0072_prefix_cached_relations.py (+7 -7)
📝 netbox/ipam/models/ip.py (+2 -67)
📝 netbox/utilities/api.py (+1 -1)
📝 netbox/virtualization/filtersets.py (+2 -1)
➕ netbox/virtualization/migrations/0046_alter_cluster__location_alter_cluster__region_and_more.py (+41 -0)
📝 netbox/virtualization/migrations/0047_natural_ordering.py (+1 -1)
📝 netbox/wireless/filtersets.py (+1 -1)

...and 2 more files

📄 Description

Fixes: #17929

Had to move the filterset mixin to it's own file as there was a circular dependency - this requires updating previous imports that reference it.

Note: The mixin uses %(class)s for the related_name which resolves to "_prefixs" instead of "_prefixes" which isn't great, but it is an internal field that shouldn't really be references, so shouldn't be much of an issue.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/17930 **Author:** [@arthanson](https://github.com/arthanson) **Created:** 11/4/2024 **Status:** ✅ Merged **Merged:** 11/15/2024 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `feature` ← **Head:** `17929-prefix-scope` --- ### 📝 Commits (10+) - [`5189b1d`](https://github.com/netbox-community/netbox/commit/5189b1df190e34443a3dda7587d6e1be468c856b) 17929 Add Scope Mixins to Prefix - [`8f8376f`](https://github.com/netbox-community/netbox/commit/8f8376f0e14c875469475c2c323528e25b49e03e) 17929 Add Scope Mixins to Prefix - [`4a0f2e9`](https://github.com/netbox-community/netbox/commit/4a0f2e9d0b6f2ac3da6fc640adad8119581af742) 17929 fixes for tests - [`ee274c8`](https://github.com/netbox-community/netbox/commit/ee274c8451efb89e1bbe050f5bcef7e9d501a41d) Merge branch 'feature' into 17929-prefix-scope - [`287a647`](https://github.com/netbox-community/netbox/commit/287a64798d9c615643bfe13edcb631ec91a4dbd5) 17929 merge latest scope changes - [`805954e`](https://github.com/netbox-community/netbox/commit/805954eb87b441dc46129bd50a43c1f6fa4e6d8c) Merge branch 'feature' into 17929-prefix-scope - [`2d367ee`](https://github.com/netbox-community/netbox/commit/2d367eec102f2743950bc8c6e6074240ec7d982c) 12596 review changes - [`19384f8`](https://github.com/netbox-community/netbox/commit/19384f8f8cd8e455aff775cf6aba085bda016e20) 12596 review changes - [`0e29f54`](https://github.com/netbox-community/netbox/commit/0e29f5468594c749182a0a9a0596d591004bd751) 12596 review changes - [`cd3b376`](https://github.com/netbox-community/netbox/commit/cd3b3768676b0d3a7231d75f0afd5b285f043db6) 12596 review changes ### 📊 Changes **22 files changed** (+187 additions, -290 deletions) <details> <summary>View changed files</summary> 📝 `netbox/dcim/api/serializers_/sites.py` (+4 -4) ➕ `netbox/dcim/base_filtersets.py` (+67 -0) 📝 `netbox/dcim/filtersets.py` (+0 -58) 📝 `netbox/dcim/graphql/types.py` (+4 -4) 📝 `netbox/dcim/models/mixins.py` (+0 -4) 📝 `netbox/ipam/api/serializers_/ip.py` (+3 -2) 📝 `netbox/ipam/apps.py` (+1 -1) 📝 `netbox/ipam/constants.py` (+0 -5) 📝 `netbox/ipam/filtersets.py` (+3 -53) 📝 `netbox/ipam/forms/bulk_edit.py` (+2 -28) 📝 `netbox/ipam/forms/bulk_import.py` (+3 -7) 📝 `netbox/ipam/forms/model_forms.py` (+2 -44) 📝 `netbox/ipam/graphql/types.py` (+1 -1) 📝 `netbox/ipam/migrations/0072_prefix_cached_relations.py` (+7 -7) 📝 `netbox/ipam/models/ip.py` (+2 -67) 📝 `netbox/utilities/api.py` (+1 -1) 📝 `netbox/virtualization/filtersets.py` (+2 -1) ➕ `netbox/virtualization/migrations/0046_alter_cluster__location_alter_cluster__region_and_more.py` (+41 -0) 📝 `netbox/virtualization/migrations/0047_natural_ordering.py` (+1 -1) 📝 `netbox/wireless/filtersets.py` (+1 -1) _...and 2 more files_ </details> ### 📄 Description ### Fixes: #17929 Had to move the filterset mixin to it's own file as there was a circular dependency - this requires updating previous imports that reference it. Note: The mixin uses %(class)s for the related_name which resolves to "_prefixs" instead of "_prefixes" which isn't great, but it is an internal field that shouldn't really be references, so shouldn't be much of an issue. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 00:20:44 +01:00
adam closed this issue 2025-12-30 00:20:44 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#15230
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?