starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #17848] [MERGED] 7699 Add Scope to Cluster #15215

New Issue
Closed
opened 2025-12-30 00:20:39 +01:00 by adam · 0 comments
adam commented 2025-12-30 00:20:39 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/17848
Author: @arthanson
Created: 10/23/2024
Status: ✅ Merged
Merged: 11/1/2024
Merged by: @jeremystretch

Base: feature ← Head: 7699-cluster-location

📝 Commits (10+)

📊 Changes

29 files changed (+588 additions, -156 deletions)

View changed files

📝 docs/models/virtualization/cluster.md (+2 -2)
📝 netbox/dcim/constants.py (+5 -0)
📝 netbox/dcim/filtersets.py (+58 -0)
➕ netbox/dcim/forms/mixins.py (+105 -0)
📝 netbox/dcim/graphql/types.py (+17 -0)
📝 netbox/dcim/models/devices.py (+9 -2)
📝 netbox/dcim/models/mixins.py (+85 -0)
📝 netbox/dcim/tests/test_models.py (+5 -4)
📝 netbox/extras/tests/test_models.py (+2 -2)
📝 netbox/ipam/querysets.py (+1 -1)
📝 netbox/ipam/tests/test_filtersets.py (+5 -4)
📝 netbox/templates/virtualization/cluster.html (+6 -2)
📝 netbox/virtualization/api/serializers_/clusters.py (+27 -4)
📝 netbox/virtualization/apps.py (+1 -1)
📝 netbox/virtualization/filtersets.py (+3 -39)
📝 netbox/virtualization/forms/bulk_edit.py (+5 -23)
📝 netbox/virtualization/forms/bulk_import.py (+6 -2)
📝 netbox/virtualization/forms/filtersets.py (+12 -7)
📝 netbox/virtualization/forms/model_forms.py (+5 -9)
📝 netbox/virtualization/graphql/types.py (+11 -4)

...and 9 more files

📄 Description

Fixes: #7699

Added mixins as well, not sure if they should be in netbox/ or dcim/ but the filtersets would need to be in something like filterset_mixins, so not sure if that is good. Can move them if desired.

Once this is approved will make a separate PR to move the already implemented scoped models to use these mixins.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/17848 **Author:** [@arthanson](https://github.com/arthanson) **Created:** 10/23/2024 **Status:** ✅ Merged **Merged:** 11/1/2024 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `feature` ← **Head:** `7699-cluster-location` --- ### 📝 Commits (10+) - [`2bb49d7`](https://github.com/netbox-community/netbox/commit/2bb49d7db6311fe8bc46ac6e81ebf54a0866b873) 7699 Add Scope to Cluster - [`dcb3c7c`](https://github.com/netbox-community/netbox/commit/dcb3c7c113670dfc5129d78ba90f3577809e285a) 7699 Serializer - [`33b4beb`](https://github.com/netbox-community/netbox/commit/33b4beba10eab1344aa4758164eadd387151af45) 7699 filterset - [`286f56b`](https://github.com/netbox-community/netbox/commit/286f56bfc60330b58ca45365147896a22c94db80) 7699 bulk_edit - [`4c3d1ce`](https://github.com/netbox-community/netbox/commit/4c3d1ce95b8ce1bb771d1fdd0e9347250157353c) 7699 bulk_import - [`d19cef4`](https://github.com/netbox-community/netbox/commit/d19cef49740a32afb22028031dbf721c176e288b) 7699 model_form - [`7e6bb0e`](https://github.com/netbox-community/netbox/commit/7e6bb0e6bc628d0972378dfbf0f5487a15c5e434) 7699 graphql, tables - [`8a63707`](https://github.com/netbox-community/netbox/commit/8a6370738691025000b4572c2a5636f666574d6e) 7699 fixes - [`be59775`](https://github.com/netbox-community/netbox/commit/be59775d568d68d0dc91a573fc468804bae1fa75) 7699 fixes - [`76e438d`](https://github.com/netbox-community/netbox/commit/76e438dea9f0c0e863ea59faf250ae91879dcade) 7699 fixes ### 📊 Changes **29 files changed** (+588 additions, -156 deletions) <details> <summary>View changed files</summary> 📝 `docs/models/virtualization/cluster.md` (+2 -2) 📝 `netbox/dcim/constants.py` (+5 -0) 📝 `netbox/dcim/filtersets.py` (+58 -0) ➕ `netbox/dcim/forms/mixins.py` (+105 -0) 📝 `netbox/dcim/graphql/types.py` (+17 -0) 📝 `netbox/dcim/models/devices.py` (+9 -2) 📝 `netbox/dcim/models/mixins.py` (+85 -0) 📝 `netbox/dcim/tests/test_models.py` (+5 -4) 📝 `netbox/extras/tests/test_models.py` (+2 -2) 📝 `netbox/ipam/querysets.py` (+1 -1) 📝 `netbox/ipam/tests/test_filtersets.py` (+5 -4) 📝 `netbox/templates/virtualization/cluster.html` (+6 -2) 📝 `netbox/virtualization/api/serializers_/clusters.py` (+27 -4) 📝 `netbox/virtualization/apps.py` (+1 -1) 📝 `netbox/virtualization/filtersets.py` (+3 -39) 📝 `netbox/virtualization/forms/bulk_edit.py` (+5 -23) 📝 `netbox/virtualization/forms/bulk_import.py` (+6 -2) 📝 `netbox/virtualization/forms/filtersets.py` (+12 -7) 📝 `netbox/virtualization/forms/model_forms.py` (+5 -9) 📝 `netbox/virtualization/graphql/types.py` (+11 -4) _...and 9 more files_ </details> ### 📄 Description ### Fixes: #7699 Added mixins as well, not sure if they should be in netbox/ or dcim/ but the filtersets would need to be in something like filterset_mixins, so not sure if that is good. Can move them if desired. Once this is approved will make a separate PR to move the already implemented scoped models to use these mixins. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 00:20:39 +01:00
adam closed this issue 2025-12-30 00:20:40 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#15215
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?