starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-13 22:03:32 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #17821] [MERGED] 9604 Add Termination to CircuitTermination #15208

New Issue
Closed
opened 2025-12-30 00:20:37 +01:00 by adam · 0 comments
adam commented 2025-12-30 00:20:37 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/17821
Author: @arthanson
Created: 10/21/2024
Status: ✅ Merged
Merged: 10/31/2024
Merged by: @jeremystretch

Base: feature ← Head: 9604-circuit-termination-location-2

📝 Commits (10+)

📊 Changes

24 files changed (+649 additions, -211 deletions)

View changed files

📝 docs/models/circuits/circuittermination.md (+2 -6)
📝 netbox/circuits/api/serializers_/circuits.py (+45 -6)
➕ netbox/circuits/constants.py (+4 -0)
📝 netbox/circuits/filtersets.py (+59 -17)
📝 netbox/circuits/forms/bulk_edit.py (+37 -17)
📝 netbox/circuits/forms/bulk_import.py (+15 -15)
📝 netbox/circuits/forms/filtersets.py (+18 -7)
📝 netbox/circuits/forms/model_forms.py (+48 -15)
📝 netbox/circuits/graphql/types.py (+12 -4)
➕ netbox/circuits/migrations/0047_circuittermination__termination.py (+56 -0)
➕ netbox/circuits/migrations/0048_circuitterminations_cached_relations.py (+90 -0)
📝 netbox/circuits/models/circuits.py (+81 -13)
📝 netbox/circuits/tables/circuits.py (+41 -11)
📝 netbox/circuits/tests/test_api.py (+8 -6)
📝 netbox/circuits/tests/test_filtersets.py (+26 -22)
📝 netbox/circuits/tests/test_views.py (+27 -19)
📝 netbox/circuits/views.py (+4 -7)
📝 netbox/dcim/graphql/types.py (+16 -1)
📝 netbox/dcim/models/cables.py (+6 -6)
📝 netbox/dcim/tests/test_cablepaths.py (+15 -15)

...and 4 more files

📄 Description

Fixes: #9604

As per review comments:

  • Changed from using scope to termination
  • changed _sitegroup to _site_group
  • changed related names to not use underscore

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/17821 **Author:** [@arthanson](https://github.com/arthanson) **Created:** 10/21/2024 **Status:** ✅ Merged **Merged:** 10/31/2024 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `feature` ← **Head:** `9604-circuit-termination-location-2` --- ### 📝 Commits (10+) - [`f1a62f3`](https://github.com/netbox-community/netbox/commit/f1a62f3a6a91403dfe504c4f8293bffd3eccad67) 9604 add scope type to CircuitTermination - [`cfdbd74`](https://github.com/netbox-community/netbox/commit/cfdbd74e9442784b292daa35ec0cf889a679e921) 9604 add scope type to CircuitTermination - [`3bbd3e3`](https://github.com/netbox-community/netbox/commit/3bbd3e3793df472dcd3d33eccad759296583f8b2) 9604 add scope type to CircuitTermination - [`218d7a0`](https://github.com/netbox-community/netbox/commit/218d7a0525a12ef293a8d1bb8a432acbbf9727ad) 9604 model_forms - [`5dfbd4a`](https://github.com/netbox-community/netbox/commit/5dfbd4ac8b53baa3c63b3c7dbee25144388f8a97) 9604 form filtersets - [`30c5fa8`](https://github.com/netbox-community/netbox/commit/30c5fa8c7a14e4480c0b883355e98e1be6e1f775) 9604 form bulk_import - [`8ba899d`](https://github.com/netbox-community/netbox/commit/8ba899d1c73e87c35fc23af306a850becfbb785c) 9604 form bulk_edit - [`489ccc9`](https://github.com/netbox-community/netbox/commit/489ccc9725bb80d8ffeb0e1a81ee9960c845e2f6) 9604 serializers - [`e35c98e`](https://github.com/netbox-community/netbox/commit/e35c98e2e6ec4cac21596aad6963c3c565959be9) 9604 graphql - [`3bde152`](https://github.com/netbox-community/netbox/commit/3bde152b84707be0950caa1f5299e340ea8aaceb) 9604 tests and detail template ### 📊 Changes **24 files changed** (+649 additions, -211 deletions) <details> <summary>View changed files</summary> 📝 `docs/models/circuits/circuittermination.md` (+2 -6) 📝 `netbox/circuits/api/serializers_/circuits.py` (+45 -6) ➕ `netbox/circuits/constants.py` (+4 -0) 📝 `netbox/circuits/filtersets.py` (+59 -17) 📝 `netbox/circuits/forms/bulk_edit.py` (+37 -17) 📝 `netbox/circuits/forms/bulk_import.py` (+15 -15) 📝 `netbox/circuits/forms/filtersets.py` (+18 -7) 📝 `netbox/circuits/forms/model_forms.py` (+48 -15) 📝 `netbox/circuits/graphql/types.py` (+12 -4) ➕ `netbox/circuits/migrations/0047_circuittermination__termination.py` (+56 -0) ➕ `netbox/circuits/migrations/0048_circuitterminations_cached_relations.py` (+90 -0) 📝 `netbox/circuits/models/circuits.py` (+81 -13) 📝 `netbox/circuits/tables/circuits.py` (+41 -11) 📝 `netbox/circuits/tests/test_api.py` (+8 -6) 📝 `netbox/circuits/tests/test_filtersets.py` (+26 -22) 📝 `netbox/circuits/tests/test_views.py` (+27 -19) 📝 `netbox/circuits/views.py` (+4 -7) 📝 `netbox/dcim/graphql/types.py` (+16 -1) 📝 `netbox/dcim/models/cables.py` (+6 -6) 📝 `netbox/dcim/tests/test_cablepaths.py` (+15 -15) _...and 4 more files_ </details> ### 📄 Description ### Fixes: #9604 As per review comments: * Changed from using scope to termination * changed _sitegroup to _site_group * changed related names to not use underscore --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 00:20:37 +01:00
adam closed this issue 2025-12-30 00:20:37 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#15208
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?