starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-13 22:03:32 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #17790] [MERGED] Fixes: #17732 - Add a background-color to img elements in docs to ensure readability in dark mode #15200

New Issue
Closed
opened 2025-12-30 00:20:34 +01:00 by adam · 0 comments
adam commented 2025-12-30 00:20:34 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/17790
Author: @bctiemann
Created: 10/16/2024
Status: ✅ Merged
Merged: 10/18/2024
Merged by: @jeremystretch

Base: develop ← Head: 17732-png-background-color-develop

📝 Commits (4)

  • ad4a1bd Add a background-color to img elements in docs to ensure readability in dark mode
  • c097fa6 Limit style changes to those within CMS content blocks; update colors of main netbox_logo.svg
  • eb27c5f Add a white stroke to the main logo
  • 4713e58 Add light & dark mode versions of the NetBox logo

📊 Changes

5 files changed (+31 additions, -2 deletions)

View changed files

📝 docs/development/style-guide.md (+1 -1)
📝 docs/extra.css (+4 -0)
📝 docs/index.md (+2 -1)
➕ docs/netbox_logo_dark.svg (+24 -0)
📝 docs/netbox_logo_light.svg (+0 -0)

📄 Description

Fixes: #17732

Adds a background-color property to the img CSS style for docs, to ensure that PNGs with transparent backgrounds and black text are still readable even on a dark-mode background.

Screenshot 2024-10-16 at 2 18 10 PM

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/17790 **Author:** [@bctiemann](https://github.com/bctiemann) **Created:** 10/16/2024 **Status:** ✅ Merged **Merged:** 10/18/2024 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop` ← **Head:** `17732-png-background-color-develop` --- ### 📝 Commits (4) - [`ad4a1bd`](https://github.com/netbox-community/netbox/commit/ad4a1bd7cddee6da3c9c9945a232e922ca7a09e1) Add a background-color to img elements in docs to ensure readability in dark mode - [`c097fa6`](https://github.com/netbox-community/netbox/commit/c097fa60a67c5765658b37944cc1c40a29afac26) Limit style changes to those within CMS content blocks; update colors of main netbox_logo.svg - [`eb27c5f`](https://github.com/netbox-community/netbox/commit/eb27c5fba077c7bc0bf567ad5362ef72284ccbbc) Add a white stroke to the main logo - [`4713e58`](https://github.com/netbox-community/netbox/commit/4713e587760b3447056d9fedbb6597a8344338a9) Add light & dark mode versions of the NetBox logo ### 📊 Changes **5 files changed** (+31 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `docs/development/style-guide.md` (+1 -1) 📝 `docs/extra.css` (+4 -0) 📝 `docs/index.md` (+2 -1) ➕ `docs/netbox_logo_dark.svg` (+24 -0) 📝 `docs/netbox_logo_light.svg` (+0 -0) </details> ### 📄 Description ### Fixes: #17732 Adds a `background-color` property to the `img` CSS style for docs, to ensure that PNGs with transparent backgrounds and black text are still readable even on a dark-mode background. <img width="953" alt="Screenshot 2024-10-16 at 2 18 10 PM" src="https://github.com/user-attachments/assets/86d6e945-a29e-4239-8f99-4344a43a3292"> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 00:20:34 +01:00
adam closed this issue 2025-12-30 00:20:34 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#15200
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?