[PR #17788] [MERGED] Fixes: #17740 - Add webp to the list of acceptable extensions for handling filenames in image_upload #15198

New Issue

adam · 2025-12-30T00:20:33+01:00

adam commented

2025-12-30 00:20:33 +01:00

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/17788
Author: @bctiemann
Created: 10/16/2024
Status: ✅ Merged
Merged: 10/16/2024
Merged by: @jeremystretch

Base: develop ← Head: 17740-add-webp-to-image_upload-develop

📝 Commits (1)

664526d Add webp to the list of acceptable extensions for handling filenames in image_upload

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 netbox/extras/utils.py (+1 -1)

📄 Description

Fixes: #17740

This ensures that image files with a .webp extension will be handled the same way as png, jpg, jpeg, etc. in that the appropriate extension will be appended to the saved file in media.

This addresses a knock-on issue raised in #17740 that a filename with multiple dots will have the rightmost dotted segment treated as the "extension", resulting in a (seemingly) unopenable file after download from NetBox.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/17788 **Author:** [@bctiemann](https://github.com/bctiemann) **Created:** 10/16/2024 **Status:** ✅ Merged **Merged:** 10/16/2024 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop` ← **Head:** `17740-add-webp-to-image_upload-develop` --- ### 📝 Commits (1) - [`664526d`](https://github.com/netbox-community/netbox/commit/664526de546e8cf0d861bc17246379fcc084ef92) Add webp to the list of acceptable extensions for handling filenames in image_upload ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `netbox/extras/utils.py` (+1 -1) </details> ### 📄 Description ### Fixes: #17740 This ensures that image files with a `.webp` extension will be handled the same way as `png`, `jpg`, `jpeg`, etc. in that the appropriate extension will be appended to the saved file in `media`. This addresses a knock-on issue raised in #17740 that a filename with multiple dots will have the rightmost dotted segment treated as the "extension", resulting in a (seemingly) unopenable file after download from NetBox. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-30 00:20:33 +01:00

adam closed this issue

2025-12-30 00:20:34 +01:00

Sign in to join this conversation.

Branches Tags

main

21142-device-component-graphql-filters

21050-device-oob-ip-may-become-orphaned

21102-fix-graphiql-explorer

20911-dropdown

20239-plugin-menu-classes-mutable-state

21097-graphql-id-lookups

feature

fix_module_substitution

20923-dcim-templates

20044-elevation-stuck-lightmode

feature-ip-prefix-link

v4.5-beta1-release

20068-import-moduletype-attrs

20766-fix-german-translation-code-literals

20378-del-script

7604-filter-modifiers-v3

circuit-swap

12318-case-insensitive-uniqueness

20637-improve-device-q-filter

20660-script-load

19724-graphql

20614-update-ruff

14884-script

02496-max-page

19720-macaddress-interface-generic-relation

19408-circuit-terminations-export-templates

20203-openapi-check

fix-19669-api-image-download

7604-filter-modifiers

19275-fixes-interface-bulk-edit

fix-17794-get_field_value_return_list

11507-show-aggregate-and-rir-on-api

9583-add_column_specific_search_field_to_tables

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/netbox#15198