starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-14 06:13:32 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #17784] [CLOSED] Fixes: #17732 - PNG background color in docs #15194

New Issue
Closed
opened 2025-12-30 00:20:32 +01:00 by adam · 0 comments
adam commented 2025-12-30 00:20:32 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/17784
Author: @bctiemann
Created: 10/16/2024
Status: ❌ Closed

Base: feature ← Head: 17732-png-background-color

📝 Commits (1)

  • 510110f Add a background-color to img elements in docs to ensure readability in dark mode

📊 Changes

1 file changed (+1 additions, -0 deletions)

View changed files

📝 docs/extra.css (+1 -0)

📄 Description

Fixes: #17732

Adds a background-color property to the img CSS style for docs, to ensure that PNGs with transparent backgrounds and black text are still readable even on a dark-mode background.

Screenshot 2024-10-16 at 2 18 10 PM

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/17784 **Author:** [@bctiemann](https://github.com/bctiemann) **Created:** 10/16/2024 **Status:** ❌ Closed **Base:** `feature` ← **Head:** `17732-png-background-color` --- ### 📝 Commits (1) - [`510110f`](https://github.com/netbox-community/netbox/commit/510110fb1c44a0911fad799a15ee143a4651debc) Add a background-color to img elements in docs to ensure readability in dark mode ### 📊 Changes **1 file changed** (+1 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `docs/extra.css` (+1 -0) </details> ### 📄 Description ### Fixes: #17732 Adds a `background-color` property to the `img` CSS style for docs, to ensure that PNGs with transparent backgrounds and black text are still readable even on a dark-mode background. <img width="953" alt="Screenshot 2024-10-16 at 2 18 10 PM" src="https://github.com/user-attachments/assets/86d6e945-a29e-4239-8f99-4344a43a3292"> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 00:20:32 +01:00
adam closed this issue 2025-12-30 00:20:32 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#15194
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?