starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #17734] [MERGED] Closes #17733: Replace pycodestyle with ruff #15178

New Issue
Closed
opened 2025-12-30 00:20:26 +01:00 by adam · 0 comments
adam commented 2025-12-30 00:20:26 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/17734
Author: @jeremystretch
Created: 10/10/2024
Status: ✅ Merged
Merged: 10/11/2024
Merged by: @jeremystretch

Base: develop ← Head: 17733-ruff

📝 Commits (8)

📊 Changes

65 files changed (+166 additions, -197 deletions)

View changed files

📝 .github/workflows/ci.yml (+2 -2)
📝 docs/development/getting-started.md (+2 -2)
📝 docs/development/style-guide.md (+16 -16)
📝 netbox/circuits/api/nested_serializers.py (+1 -1)
📝 netbox/circuits/tests/test_views.py (+1 -1)
📝 netbox/core/api/nested_serializers.py (+1 -1)
📝 netbox/core/data_backends.py (+1 -1)
📝 netbox/core/graphql/mixins.py (+1 -1)
📝 netbox/core/management/commands/syncdatasource.py (+2 -2)
📝 netbox/core/models/data.py (+1 -1)
📝 netbox/core/models/jobs.py (+2 -2)
📝 netbox/dcim/api/nested_serializers.py (+1 -1)
📝 netbox/dcim/forms/object_create.py (+2 -2)
📝 netbox/dcim/graphql/mixins.py (+20 -20)
📝 netbox/dcim/management/commands/trace_paths.py (+1 -1)
📝 netbox/dcim/models/device_component_templates.py (+0 -1)
📝 netbox/dcim/tables/devicetypes.py (+1 -2)
📝 netbox/dcim/tests/test_api.py (+2 -2)
📝 netbox/dcim/tests/test_filtersets.py (+0 -7)
📝 netbox/dcim/tests/test_models.py (+26 -28)

...and 45 more files

📄 Description

Closes: #17733

  • Replace pycdoestyle with ruff in the CI workflow and pre-commit script
  • Clean up/ignore rule violations as needed throughout the code base
  • Update developer documentation

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/17734 **Author:** [@jeremystretch](https://github.com/jeremystretch) **Created:** 10/10/2024 **Status:** ✅ Merged **Merged:** 10/11/2024 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop` ← **Head:** `17733-ruff` --- ### 📝 Commits (8) - [`4b3f6e5`](https://github.com/netbox-community/netbox/commit/4b3f6e5fbbe5457e8a5e3e8b7140f86ff74c60f7) Resolve F541 errors - [`f40a8af`](https://github.com/netbox-community/netbox/commit/f40a8af81a7962bb2fc16e1a09022fa2ab4f12a0) Resolve F841 errors - [`38b2457`](https://github.com/netbox-community/netbox/commit/38b245700a297da78eb02a1d93a211342fa931f6) Resolve F811 errors - [`0398b5f`](https://github.com/netbox-community/netbox/commit/0398b5fed18d2dac607c69436589597a802b94bb) Resolve F901 errors - [`c7046ef`](https://github.com/netbox-community/netbox/commit/c7046ef695167b116c2663deada25493c7a9c76b) Resolve E714 errors - [`89d490c`](https://github.com/netbox-community/netbox/commit/89d490cc69aa8ca0943de60780879943d8a62570) Ignore F821 errors for GraphQL mixins - [`3758391`](https://github.com/netbox-community/netbox/commit/3758391ecd3df73990f724eab8129380596bf6ac) Replace pycodestyle with ruff - [`296e8f4`](https://github.com/netbox-community/netbox/commit/296e8f4fa724181ad3e3b607a852c3b6d3e18386) Move ignores to ruff.toml ### 📊 Changes **65 files changed** (+166 additions, -197 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/ci.yml` (+2 -2) 📝 `docs/development/getting-started.md` (+2 -2) 📝 `docs/development/style-guide.md` (+16 -16) 📝 `netbox/circuits/api/nested_serializers.py` (+1 -1) 📝 `netbox/circuits/tests/test_views.py` (+1 -1) 📝 `netbox/core/api/nested_serializers.py` (+1 -1) 📝 `netbox/core/data_backends.py` (+1 -1) 📝 `netbox/core/graphql/mixins.py` (+1 -1) 📝 `netbox/core/management/commands/syncdatasource.py` (+2 -2) 📝 `netbox/core/models/data.py` (+1 -1) 📝 `netbox/core/models/jobs.py` (+2 -2) 📝 `netbox/dcim/api/nested_serializers.py` (+1 -1) 📝 `netbox/dcim/forms/object_create.py` (+2 -2) 📝 `netbox/dcim/graphql/mixins.py` (+20 -20) 📝 `netbox/dcim/management/commands/trace_paths.py` (+1 -1) 📝 `netbox/dcim/models/device_component_templates.py` (+0 -1) 📝 `netbox/dcim/tables/devicetypes.py` (+1 -2) 📝 `netbox/dcim/tests/test_api.py` (+2 -2) 📝 `netbox/dcim/tests/test_filtersets.py` (+0 -7) 📝 `netbox/dcim/tests/test_models.py` (+26 -28) _...and 45 more files_ </details> ### 📄 Description ### Closes: #17733 - Replace `pycdoestyle` with `ruff` in the CI workflow and pre-commit script - Clean up/ignore rule violations as needed throughout the code base - Update developer documentation --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 00:20:26 +01:00
adam closed this issue 2025-12-30 00:20:26 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#15178
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?