starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-14 06:13:32 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #17731] [MERGED] 17614 Disallow removal of virtual chassis from device if set as master #15177

New Issue
Closed
opened 2025-12-30 00:20:26 +01:00 by adam · 0 comments
adam commented 2025-12-30 00:20:26 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/17731
Author: @arthanson
Created: 10/10/2024
Status: ✅ Merged
Merged: 10/11/2024
Merged by: @jeremystretch

Base: develop ← Head: 17614-virtual-chassis-master

📝 Commits (3)

  • 1bb2656 17614 Disallow removal of virtual chassis from device if set as master
  • 3f50b4f 17614 review changes
  • 7f91752 17614 review changes

📊 Changes

1 file changed (+7 additions, -0 deletions)

View changed files

📝 netbox/dcim/models/devices.py (+7 -0)

📄 Description

Fixes: #17614

Raise error if removing the virtual chassis from a device if it is set as master. We could auto-remove it from master on the virtual-chassis, but it seems like in other places we disallow the removal so keeping it consistent.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/17731 **Author:** [@arthanson](https://github.com/arthanson) **Created:** 10/10/2024 **Status:** ✅ Merged **Merged:** 10/11/2024 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop` ← **Head:** `17614-virtual-chassis-master` --- ### 📝 Commits (3) - [`1bb2656`](https://github.com/netbox-community/netbox/commit/1bb2656c4209bdb7e253c88b44b64688344652e1) 17614 Disallow removal of virtual chassis from device if set as master - [`3f50b4f`](https://github.com/netbox-community/netbox/commit/3f50b4f412b90b74263360860c859d25080efa15) 17614 review changes - [`7f91752`](https://github.com/netbox-community/netbox/commit/7f91752092a0ce2bfac7b94ac29610dbae9d8e2c) 17614 review changes ### 📊 Changes **1 file changed** (+7 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `netbox/dcim/models/devices.py` (+7 -0) </details> ### 📄 Description ### Fixes: #17614 Raise error if removing the virtual chassis from a device if it is set as master. We could auto-remove it from master on the virtual-chassis, but it seems like in other places we disallow the removal so keeping it consistent. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 00:20:26 +01:00
adam closed this issue 2025-12-30 00:20:26 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#15177
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?