[PR #17691] [MERGED] Fix parsing of extra_choices #15165

New Issue

adam · 2025-12-30T00:20:21+01:00

adam commented

2025-12-30 00:20:21 +01:00

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/17691
Author: @gellis713
Created: 10/7/2024
Status: ✅ Merged
Merged: 10/9/2024
Merged by: @jeremystretch

Base: develop ← Head: 17562-graphql-choiceset

📝 Commits (2)

5a032c2 Align strawberry resolver with expected return type
daee62c Align test data with expected representation of extra_choices in CustomFieldChoiceSet model

📊 Changes

2 files changed (+13 additions, -4 deletions)

View changed files

📝 netbox/extras/graphql/types.py (+1 -1)
📝 netbox/extras/tests/test_api.py (+12 -3)

📄 Description

Fixes: https://github.com/netbox-community/netbox/issues/17562

Updates extra_choices to be a list of a list of strings which is what Django reports as the relevant types at each level. In addition, it seems some of the test data for extra_choices was a list of strings instead of a nested list.

The form code in CustomFieldChoiceSetForm automatically takes single-items and creates a label so there is a list of tuples being passed into the model.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/17691 **Author:** [@gellis713](https://github.com/gellis713) **Created:** 10/7/2024 **Status:** ✅ Merged **Merged:** 10/9/2024 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop` ← **Head:** `17562-graphql-choiceset` --- ### 📝 Commits (2) - [`5a032c2`](https://github.com/netbox-community/netbox/commit/5a032c234574ea0f5df7fd94bed24b8bf0ad1f75) Align strawberry resolver with expected return type - [`daee62c`](https://github.com/netbox-community/netbox/commit/daee62c4e7ac3cdfbda7f692861ca01b1862cbdd) Align test data with expected representation of extra_choices in CustomFieldChoiceSet model ### 📊 Changes **2 files changed** (+13 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `netbox/extras/graphql/types.py` (+1 -1) 📝 `netbox/extras/tests/test_api.py` (+12 -3) </details> ### 📄 Description Fixes: https://github.com/netbox-community/netbox/issues/17562 Updates extra_choices to be a list of a list of strings which is what Django reports as the relevant types at each level. In addition, it seems some of the test data for extra_choices was a list of strings instead of a nested list. The form code in CustomFieldChoiceSetForm automatically takes single-items and creates a label so there is a list of tuples being passed into the model. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-30 00:20:21 +01:00

adam closed this issue

2025-12-30 00:20:21 +01:00

Sign in to join this conversation.

Branches Tags

main

21142-device-component-graphql-filters

21050-device-oob-ip-may-become-orphaned

21102-fix-graphiql-explorer

20911-dropdown

20239-plugin-menu-classes-mutable-state

21097-graphql-id-lookups

feature

fix_module_substitution

20923-dcim-templates

20044-elevation-stuck-lightmode

feature-ip-prefix-link

v4.5-beta1-release

20068-import-moduletype-attrs

20766-fix-german-translation-code-literals

20378-del-script

7604-filter-modifiers-v3

circuit-swap

12318-case-insensitive-uniqueness

20637-improve-device-q-filter

20660-script-load

19724-graphql

20614-update-ruff

14884-script

02496-max-page

19720-macaddress-interface-generic-relation

19408-circuit-terminations-export-templates

20203-openapi-check

fix-19669-api-image-download

7604-filter-modifiers

19275-fixes-interface-bulk-edit

fix-17794-get_field_value_return_list

11507-show-aggregate-and-rir-on-api

9583-add_column_specific_search_field_to_tables

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/netbox#15165