starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-14 06:13:32 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #17661] [MERGED] Fixes: #17566 - Fix issue Job.get_absolute_url() to prevent exception being thrown if no object_type is set #15156

New Issue
Closed
opened 2025-12-30 00:20:19 +01:00 by adam · 0 comments
adam commented 2025-12-30 00:20:19 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/17661
Author: @DanSheps
Created: 10/2/2024
Status: ✅ Merged
Merged: 10/7/2024
Merged by: @jeremystretch

Base: develop ← Head: 17566-fix-get_absolute_url

📝 Commits (3)

  • 57e3f41 Fixes: #17566 - Fix issue Job.get_absolute_url() to prevent exception being thrown if no object_type is set
  • abd1107 Add back whitespace after statements
  • ae51e7d Remove whitespace. Change to if statement

📊 Changes

1 file changed (+5 additions, -4 deletions)

View changed files

📝 netbox/core/models/jobs.py (+5 -4)

📄 Description

Fixes: #17566 - Fix issue Job.get_absolute_url() to prevent exception being thrown if no object_type is set

  • Add wrapper statement to check for self.object_type

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/17661 **Author:** [@DanSheps](https://github.com/DanSheps) **Created:** 10/2/2024 **Status:** ✅ Merged **Merged:** 10/7/2024 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop` ← **Head:** `17566-fix-get_absolute_url` --- ### 📝 Commits (3) - [`57e3f41`](https://github.com/netbox-community/netbox/commit/57e3f4143e408ad8b03f935fbb54e64b5e0aa7fd) Fixes: #17566 - Fix issue `Job.get_absolute_url()` to prevent exception being thrown if no object_type is set - [`abd1107`](https://github.com/netbox-community/netbox/commit/abd1107cb3cfed954e6b82d4318b556169af6ac8) Add back whitespace after statements - [`ae51e7d`](https://github.com/netbox-community/netbox/commit/ae51e7d4d889b3390315ad96ebb33ef10f274ce7) Remove whitespace. Change to if statement ### 📊 Changes **1 file changed** (+5 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `netbox/core/models/jobs.py` (+5 -4) </details> ### 📄 Description Fixes: #17566 - Fix issue `Job.get_absolute_url()` to prevent exception being thrown if no object_type is set * Add wrapper statement to check for self.object_type --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 00:20:19 +01:00
adam closed this issue 2025-12-30 00:20:19 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#15156
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?