starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #17657] [MERGED] Fixes: #17648 - Fix exception thrown in Job.delete() when no object_type specified #15153

New Issue
Closed
opened 2025-12-30 00:20:18 +01:00 by adam · 0 comments
adam commented 2025-12-30 00:20:18 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/17657
Author: @DanSheps
Created: 10/2/2024
Status: ✅ Merged
Merged: 10/7/2024
Merged by: @jeremystretch

Base: develop ← Head: 17648-fix-delete-of-task

📝 Commits (4)

  • 1f24876 Fixes: #17648 - Fix exception thrown in Job.delete() when no object_type specified
  • ac5b5e8 Remove unrelated fix
  • 0e98306 Change back elif to if
  • 8fe98b5 Remove unused imports

📊 Changes

1 file changed (+1 additions, -3 deletions)

View changed files

📝 netbox/core/models/jobs.py (+1 -3)

📄 Description

Fixes: #17648 - Fix exception thrown in Job.delete() when no object_type specified

  • Change Job.delete() to use get_queue_for_model
  • Fix related issue in Job.get_absolute_url()

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/17657 **Author:** [@DanSheps](https://github.com/DanSheps) **Created:** 10/2/2024 **Status:** ✅ Merged **Merged:** 10/7/2024 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop` ← **Head:** `17648-fix-delete-of-task` --- ### 📝 Commits (4) - [`1f24876`](https://github.com/netbox-community/netbox/commit/1f24876c4fc18bccc0f68fd0bc3a153b08cea7f5) Fixes: #17648 - Fix exception thrown in `Job.delete()` when no object_type specified - [`ac5b5e8`](https://github.com/netbox-community/netbox/commit/ac5b5e85bfc433feae8c26b5df59504a5fb8aeba) Remove unrelated fix - [`0e98306`](https://github.com/netbox-community/netbox/commit/0e98306503ff18ad20f68b7b11ecf0942d9a481f) Change back elif to if - [`8fe98b5`](https://github.com/netbox-community/netbox/commit/8fe98b56180b3660d73ac0686b797a3225ec7091) Remove unused imports ### 📊 Changes **1 file changed** (+1 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `netbox/core/models/jobs.py` (+1 -3) </details> ### 📄 Description Fixes: #17648 - Fix exception thrown in `Job.delete()` when no object_type specified * Change `Job.delete()` to use `get_queue_for_model` * Fix related issue in `Job.get_absolute_url()` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 00:20:18 +01:00
adam closed this issue 2025-12-30 00:20:19 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#15153
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?