starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #17638] [MERGED] Fixes #16024: Change attr_type from list to str for MultipleChoiceFilter #15152

New Issue
Closed
opened 2025-12-30 00:20:18 +01:00 by adam · 0 comments
adam commented 2025-12-30 00:20:18 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/17638
Author: @jeremystretch
Created: 9/27/2024
Status: ✅ Merged
Merged: 10/3/2024
Merged by: @jeremystretch

Base: develop ← Head: 16024-graphql-filtering

📝 Commits (1)

  • ec988b6 Change attr_type from list to str for MultipleChoiceFilter

📊 Changes

3 files changed (+42 additions, -9 deletions)

View changed files

📝 netbox/dcim/filtersets.py (+1 -1)
📝 netbox/netbox/graphql/filter_mixins.py (+4 -4)
📝 netbox/netbox/tests/test_graphql.py (+37 -4)

📄 Description

Fixes: #16024

This seems to fix the AND/OR/NOT filtering specifically for multiple-choice filters. Additional work is likely needed but I wanted to put this out there for testing.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/17638 **Author:** [@jeremystretch](https://github.com/jeremystretch) **Created:** 9/27/2024 **Status:** ✅ Merged **Merged:** 10/3/2024 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop` ← **Head:** `16024-graphql-filtering` --- ### 📝 Commits (1) - [`ec988b6`](https://github.com/netbox-community/netbox/commit/ec988b669b0c08ae298cb4d70008dbefff314429) Change attr_type from list to str for MultipleChoiceFilter ### 📊 Changes **3 files changed** (+42 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `netbox/dcim/filtersets.py` (+1 -1) 📝 `netbox/netbox/graphql/filter_mixins.py` (+4 -4) 📝 `netbox/netbox/tests/test_graphql.py` (+37 -4) </details> ### 📄 Description ### Fixes: #16024 This seems to fix the AND/OR/NOT filtering specifically for multiple-choice filters. Additional work is likely needed but I wanted to put this out there for testing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 00:20:18 +01:00
adam closed this issue 2025-12-30 00:20:18 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#15152
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?