starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-13 22:03:32 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #17593] [MERGED] Fixes: #17498 - Handle "manufacturer" field with a validation error on non-unique values in DeviceTypeImportForm #15133

New Issue
Closed
opened 2025-12-30 00:20:11 +01:00 by adam · 0 comments
adam commented 2025-12-30 00:20:11 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/17593
Author: @bctiemann
Created: 9/24/2024
Status: ✅ Merged
Merged: 9/26/2024
Merged by: @jeremystretch

Base: develop ← Head: 17498-devicetype-manufacturer-CSVModelChoiceField

📝 Commits (1)

  • ee3efa8 Change manufacturer to a CSVModelChoiceField in DeviceTypeImportForm

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 netbox/dcim/forms/bulk_import.py (+1 -1)

📄 Description

Fixes: #17498

Changes DeviceTypeImportForm.manufacturer to a CSVModelChoiceField, ensuring that non-unique values will raise a validation error rather than crashing with an opaque 500.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/17593 **Author:** [@bctiemann](https://github.com/bctiemann) **Created:** 9/24/2024 **Status:** ✅ Merged **Merged:** 9/26/2024 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop` ← **Head:** `17498-devicetype-manufacturer-CSVModelChoiceField` --- ### 📝 Commits (1) - [`ee3efa8`](https://github.com/netbox-community/netbox/commit/ee3efa8c2c2e18319a3f9e2b01e8157aebbfb0dd) Change manufacturer to a CSVModelChoiceField in DeviceTypeImportForm ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `netbox/dcim/forms/bulk_import.py` (+1 -1) </details> ### 📄 Description ### Fixes: #17498 Changes `DeviceTypeImportForm.manufacturer` to a `CSVModelChoiceField`, ensuring that non-unique values will raise a validation error rather than crashing with an opaque 500. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 00:20:11 +01:00
adam closed this issue 2025-12-30 00:20:12 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#15133
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?