starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #17591] [MERGED] 17558 raise validation error if removing used choice from ChoiceSet #15131

New Issue
Closed
opened 2025-12-30 00:20:11 +01:00 by adam · 0 comments
adam commented 2025-12-30 00:20:11 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/17591
Author: @arthanson
Created: 9/24/2024
Status: ✅ Merged
Merged: 9/30/2024
Merged by: @jeremystretch

Base: develop ← Head: 17558-custom-field

📝 Commits (6)

  • 9830321 17558 raise validation error if removing choice from choiceset that is currently used
  • b59ae0f 17558 raise validation error if removing choice from choiceset that is currently used
  • 52b8bd5 17558 raise validation error if removing choice from choiceset that is currently used
  • 822a4a4 17558 add tests
  • 0cb5d9f 17558 add tests
  • 7f372b9 Tightened up choice evaluation logic a bit; cleaned up test

📊 Changes

2 files changed (+100 additions, -0 deletions)

View changed files

📝 netbox/extras/models/customfields.py (+32 -0)
📝 netbox/extras/tests/test_customfields.py (+68 -0)

📄 Description

Fixes: #17558

Editing custom field choice set my_choice_set | NetBox 2024-09-24 09-55-19

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/17591 **Author:** [@arthanson](https://github.com/arthanson) **Created:** 9/24/2024 **Status:** ✅ Merged **Merged:** 9/30/2024 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop` ← **Head:** `17558-custom-field` --- ### 📝 Commits (6) - [`9830321`](https://github.com/netbox-community/netbox/commit/983032189abb1f0e26835f761ae71ea6da0c509a) 17558 raise validation error if removing choice from choiceset that is currently used - [`b59ae0f`](https://github.com/netbox-community/netbox/commit/b59ae0fd934273eecd22bf3d60cdbe7c2f43c753) 17558 raise validation error if removing choice from choiceset that is currently used - [`52b8bd5`](https://github.com/netbox-community/netbox/commit/52b8bd5523054a0e267a3b3c1294282409b2cf81) 17558 raise validation error if removing choice from choiceset that is currently used - [`822a4a4`](https://github.com/netbox-community/netbox/commit/822a4a4bc81b2ec339ae841590989643e7104d49) 17558 add tests - [`0cb5d9f`](https://github.com/netbox-community/netbox/commit/0cb5d9f168e10d8744ada67e10928a0615e28387) 17558 add tests - [`7f372b9`](https://github.com/netbox-community/netbox/commit/7f372b98a86c9f621903448c9900744cb48459c7) Tightened up choice evaluation logic a bit; cleaned up test ### 📊 Changes **2 files changed** (+100 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `netbox/extras/models/customfields.py` (+32 -0) 📝 `netbox/extras/tests/test_customfields.py` (+68 -0) </details> ### 📄 Description ### Fixes: #17558 ![Editing custom field choice set my_choice_set | NetBox 2024-09-24 09-55-19](https://github.com/user-attachments/assets/5755f196-7509-4627-908f-e1f3d69cddef) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 00:20:11 +01:00
adam closed this issue 2025-12-30 00:20:11 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#15131
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?