[PR #17583] [MERGED] Closes #17577: Reference ModelState when determining whether an object is being created #15129

New Issue

adam · 2025-12-30T00:20:10+01:00

adam commented

2025-12-30 00:20:10 +01:00

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/17583
Author: @jeremystretch
Created: 9/23/2024
Status: ✅ Merged
Merged: 9/24/2024
Merged by: @jeremystretch

Base: develop ← Head: 17577-check-ModelState

📝 Commits (1)

be584f2 Closes #17577: Reference ModelState when determining whether an object is being created

📊 Changes

8 files changed (+13 additions, -13 deletions)

View changed files

📝 netbox/dcim/models/cables.py (+1 -1)
📝 netbox/dcim/models/device_component_templates.py (+1 -1)
📝 netbox/dcim/models/device_components.py (+3 -3)
📝 netbox/dcim/models/devices.py (+3 -3)
📝 netbox/dcim/models/racks.py (+2 -2)
📝 netbox/netbox/models/__init__.py (+1 -1)
📝 netbox/virtualization/models/clusters.py (+1 -1)
📝 netbox/virtualization/models/virtualmachines.py (+1 -1)

📄 Description

Closes: #17577

For every instance where we're currently evaluating whether self.pk is null to determine if an object is being created or updated, instead reference its _state attribute.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/17583 **Author:** [@jeremystretch](https://github.com/jeremystretch) **Created:** 9/23/2024 **Status:** ✅ Merged **Merged:** 9/24/2024 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop` ← **Head:** `17577-check-ModelState` --- ### 📝 Commits (1) - [`be584f2`](https://github.com/netbox-community/netbox/commit/be584f24df7f0077bc5d0944ff56626c52e7bd6c) Closes #17577: Reference ModelState when determining whether an object is being created ### 📊 Changes **8 files changed** (+13 additions, -13 deletions) <details> <summary>View changed files</summary> 📝 `netbox/dcim/models/cables.py` (+1 -1) 📝 `netbox/dcim/models/device_component_templates.py` (+1 -1) 📝 `netbox/dcim/models/device_components.py` (+3 -3) 📝 `netbox/dcim/models/devices.py` (+3 -3) 📝 `netbox/dcim/models/racks.py` (+2 -2) 📝 `netbox/netbox/models/__init__.py` (+1 -1) 📝 `netbox/virtualization/models/clusters.py` (+1 -1) 📝 `netbox/virtualization/models/virtualmachines.py` (+1 -1) </details> ### 📄 Description ### Closes: #17577 For every instance where we're currently evaluating whether `self.pk` is null to determine if an object is being created or updated, instead reference its `_state` attribute. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-30 00:20:10 +01:00

adam closed this issue

2025-12-30 00:20:10 +01:00

Sign in to join this conversation.

Branches Tags

main

21050-device-oob-ip-may-become-orphaned

21102-fix-graphiql-explorer

20911-dropdown

20239-plugin-menu-classes-mutable-state

21097-graphql-id-lookups

feature

fix_module_substitution

20923-dcim-templates

20044-elevation-stuck-lightmode

feature-ip-prefix-link

v4.5-beta1-release

20068-import-moduletype-attrs

20766-fix-german-translation-code-literals

20378-del-script

7604-filter-modifiers-v3

circuit-swap

12318-case-insensitive-uniqueness

20637-improve-device-q-filter

20660-script-load

19724-graphql

20614-update-ruff

14884-script

02496-max-page

19720-macaddress-interface-generic-relation

19408-circuit-terminations-export-templates

20203-openapi-check

fix-19669-api-image-download

7604-filter-modifiers

19275-fixes-interface-bulk-edit

fix-17794-get_field_value_return_list

11507-show-aggregate-and-rir-on-api

9583-add_column_specific_search_field_to_tables

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/netbox#15129