[PR #17574] [MERGED] Closes: #16837 - Fix type__empty filter in character-based filters #15123

New Issue

adam · 2025-12-30T00:20:08+01:00

adam commented

2025-12-30 00:20:08 +01:00

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/17574
Author: @bctiemann
Created: 9/23/2024
Status: ✅ Merged
Merged: 9/24/2024
Merged by: @jeremystretch

Base: develop ← Head: 16837-filter-cable-type__empty-only

📝 Commits (2)

3f691b4 Fix type__empty filter in character-based filters
30855fb Add tests

📊 Changes

2 files changed (+9 additions, -2 deletions)

View changed files

📝 netbox/dcim/tests/test_filtersets.py (+4 -0)
📝 netbox/netbox/filtersets.py (+5 -2)

📄 Description

Fixes: #16837

Removes choices and null_value params from the extra dict on a filterset field definition during get_additional_lookups, which allows the stock filter to be inited properly, meaning we no longer need to short-circuit the set of additional lookups to enable for filters such as MultipleChoiceFilter and limit them only to FILTER_NEGATION_LOOKUP_MAP if a choices param is present.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/17574 **Author:** [@bctiemann](https://github.com/bctiemann) **Created:** 9/23/2024 **Status:** ✅ Merged **Merged:** 9/24/2024 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop` ← **Head:** `16837-filter-cable-type__empty-only` --- ### 📝 Commits (2) - [`3f691b4`](https://github.com/netbox-community/netbox/commit/3f691b4d920e43f5be175f4d0e4f4dc920a658ed) Fix type__empty filter in character-based filters - [`30855fb`](https://github.com/netbox-community/netbox/commit/30855fb2d2cbbb54966618d4d163cc9388894baa) Add tests ### 📊 Changes **2 files changed** (+9 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `netbox/dcim/tests/test_filtersets.py` (+4 -0) 📝 `netbox/netbox/filtersets.py` (+5 -2) </details> ### 📄 Description Fixes: #16837 Removes `choices` and `null_value` params from the `extra` dict on a filterset field definition during `get_additional_lookups`, which allows the stock filter to be inited properly, meaning we no longer need to short-circuit the set of additional lookups to enable for filters such as `MultipleChoiceFilter` and limit them only to `FILTER_NEGATION_LOOKUP_MAP` if a `choices` param is present. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-30 00:20:08 +01:00

adam closed this issue

2025-12-30 00:20:08 +01:00

Sign in to join this conversation.

Branches Tags

main

update-changelog-comments-docs

feature-removal-issue-type

20911-dropdown

20239-plugin-menu-classes-mutable-state

21097-graphql-id-lookups

feature

fix_module_substitution

20923-dcim-templates

20044-elevation-stuck-lightmode

feature-ip-prefix-link

v4.5-beta1-release

20068-import-moduletype-attrs

20766-fix-german-translation-code-literals

20378-del-script

7604-filter-modifiers-v3

circuit-swap

12318-case-insensitive-uniqueness

20637-improve-device-q-filter

20660-script-load

19724-graphql

20614-update-ruff

14884-script

02496-max-page

19720-macaddress-interface-generic-relation

19408-circuit-terminations-export-templates

20203-openapi-check

fix-19669-api-image-download

7604-filter-modifiers

19275-fixes-interface-bulk-edit

fix-17794-get_field_value_return_list

11507-show-aggregate-and-rir-on-api

9583-add_column_specific_search_field_to_tables

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/netbox#15123