starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-14 06:13:32 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #17563] [CLOSED] Fix parsing of extra_choices #15121

New Issue
Closed
opened 2025-12-30 00:20:08 +01:00 by adam · 0 comments
adam commented 2025-12-30 00:20:08 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/17563
Author: @gellis713
Created: 9/20/2024
Status: ❌ Closed

Base: develop ← Head: 17562-grapqhl-choiceset

📝 Commits (4)

  • 968535d Fix parsing of extra_choices
  • 6035d64 Fix failing test
  • 48d9e88 Align extra_choices syntax to match graphql expectation of iterable
  • cbd5d05 Linting

📊 Changes

2 files changed (+4 additions, -4 deletions)

View changed files

📝 netbox/extras/graphql/types.py (+1 -1)
📝 netbox/extras/tests/test_api.py (+3 -3)

📄 Description

Fixes: #17562

Updates extra_choices to be a list of a list of strings which is what Django reports as the relevant types at each level.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/17563 **Author:** [@gellis713](https://github.com/gellis713) **Created:** 9/20/2024 **Status:** ❌ Closed **Base:** `develop` ← **Head:** `17562-grapqhl-choiceset` --- ### 📝 Commits (4) - [`968535d`](https://github.com/netbox-community/netbox/commit/968535de870cefe8e230a3c3703f466873a35982) Fix parsing of extra_choices - [`6035d64`](https://github.com/netbox-community/netbox/commit/6035d64ece3ad43aa6152d0852e9e10ff6439006) Fix failing test - [`48d9e88`](https://github.com/netbox-community/netbox/commit/48d9e882f509a15000ae741ba655e64901a1f2b3) Align extra_choices syntax to match graphql expectation of iterable - [`cbd5d05`](https://github.com/netbox-community/netbox/commit/cbd5d059969c84234258a4be9fa745aeff0c0c9b) Linting ### 📊 Changes **2 files changed** (+4 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `netbox/extras/graphql/types.py` (+1 -1) 📝 `netbox/extras/tests/test_api.py` (+3 -3) </details> ### 📄 Description ### Fixes: #17562 Updates extra_choices to be a list of a list of strings which is what Django reports as the relevant types at each level. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 00:20:08 +01:00
adam closed this issue 2025-12-30 00:20:08 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#15121
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?