starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #17390] [MERGED] Fixed view permissions for ObjectChange #15085

New Issue
Closed
opened 2025-12-30 00:19:51 +01:00 by adam · 0 comments
adam commented 2025-12-30 00:19:51 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/17390
Author: @peteeckel
Created: 9/5/2024
Status: ✅ Merged
Merged: 9/5/2024
Merged by: @jeremystretch

Base: develop ← Head: 17387-changelog-permissions

📝 Commits (1)

  • af25f61 Fixed view permissions for ObjectChange

📊 Changes

3 files changed (+3 additions, -3 deletions)

View changed files

📝 netbox/netbox/views/generic/feature_views.py (+1 -1)
📝 netbox/templates/account/profile.html (+1 -1)
📝 netbox/templates/users/user.html (+1 -1)

📄 Description

Fixes: #17387

When the ObjectChange class was moved from extras to core, some instances of the permission name were missed.

This PR fixes them by replacing the extras.view_objectchange permission with core.view_objectchange.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/17390 **Author:** [@peteeckel](https://github.com/peteeckel) **Created:** 9/5/2024 **Status:** ✅ Merged **Merged:** 9/5/2024 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop` ← **Head:** `17387-changelog-permissions` --- ### 📝 Commits (1) - [`af25f61`](https://github.com/netbox-community/netbox/commit/af25f61d4ac2d47c419a3be8a6fa03a64ba3ec04) Fixed view permissions for ObjectChange ### 📊 Changes **3 files changed** (+3 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `netbox/netbox/views/generic/feature_views.py` (+1 -1) 📝 `netbox/templates/account/profile.html` (+1 -1) 📝 `netbox/templates/users/user.html` (+1 -1) </details> ### 📄 Description ### Fixes: #17387 When the `ObjectChange` class was moved from `extras` to `core`, some instances of the permission name were missed. This PR fixes them by replacing the `extras.view_objectchange` permission with `core.view_objectchange`. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 00:19:51 +01:00
adam closed this issue 2025-12-30 00:19:52 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#15085
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?