starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #17376] [MERGED] Fixes #17362: Fix unicity of VRF returned by filter_present_in_vrf function #15083

New Issue
Closed
opened 2025-12-30 00:19:51 +01:00 by adam · 0 comments
adam commented 2025-12-30 00:19:51 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/17376
Author: @pl0xym0r
Created: 9/5/2024
Status: ✅ Merged
Merged: 9/11/2024
Merged by: @jeremystretch

Base: develop ← Head: 17362-filterset-prefix-ip-update

📝 Commits (1)

  • 76a7fd5 Fixes #17362: Fix unicity of VRF returned by filter_present_in_vrf function

📊 Changes

1 file changed (+2 additions, -2 deletions)

View changed files

📝 netbox/ipam/filtersets.py (+2 -2)

📄 Description

Fixes: #17362

.distinct() permits to remove unnecessary duplicated returns of the VRF passed in parameter in the function.
This permits to have unique IP and Prefixes when using present_in_vrf / present_in_vrf_id parameter, example :

For prefixes:
image

For IP:
image

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/17376 **Author:** [@pl0xym0r](https://github.com/pl0xym0r) **Created:** 9/5/2024 **Status:** ✅ Merged **Merged:** 9/11/2024 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop` ← **Head:** `17362-filterset-prefix-ip-update` --- ### 📝 Commits (1) - [`76a7fd5`](https://github.com/netbox-community/netbox/commit/76a7fd5463f4224a5ed385906f11ccc251de3641) Fixes #17362: Fix unicity of VRF returned by filter_present_in_vrf function ### 📊 Changes **1 file changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `netbox/ipam/filtersets.py` (+2 -2) </details> ### 📄 Description ### Fixes: #17362 .distinct() permits to remove unnecessary duplicated returns of the VRF passed in parameter in the function. This permits to have unique IP and Prefixes when using `present_in_vrf ` / `present_in_vrf_id` parameter, example : For prefixes: ![image](https://github.com/user-attachments/assets/29c8a3bc-b0cf-4f55-98d8-4f0cc63fe36d) For IP: ![image](https://github.com/user-attachments/assets/b46fa49d-aa7e-4391-a8b6-f2ab23c9a5ea) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 00:19:51 +01:00
adam closed this issue 2025-12-30 00:19:51 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#15083
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?