starred/netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2026-01-11 21:10:29 +01:00
Code Issues 273 Packages Projects Releases 10 Wiki Activity

[PR #17368] [MERGED] 17354 fix import with custom-field #15078

New Issue
Closed
opened 2025-12-30 00:19:49 +01:00 by adam · 0 comments
adam commented 2025-12-30 00:19:49 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/netbox-community/netbox/pull/17368
Author: @arthanson
Created: 9/4/2024
Status: ✅ Merged
Merged: 9/4/2024
Merged by: @jeremystretch

Base: develop ← Head: 17354-cf-import

📝 Commits (2)

  • 3e51a5f 17354 fix import with custom-field
  • 098d250 17354 change to use kwargs

📊 Changes

1 file changed (+18 additions, -12 deletions)

View changed files

📝 netbox/extras/models/customfields.py (+18 -12)

📄 Description

Fixes: #17354

Only DynamicModelChoiceField has query_params, CSVModelChoiceField does not so this only includes the parameter if the field is of the correct type.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netbox-community/netbox/pull/17368 **Author:** [@arthanson](https://github.com/arthanson) **Created:** 9/4/2024 **Status:** ✅ Merged **Merged:** 9/4/2024 **Merged by:** [@jeremystretch](https://github.com/jeremystretch) **Base:** `develop` ← **Head:** `17354-cf-import` --- ### 📝 Commits (2) - [`3e51a5f`](https://github.com/netbox-community/netbox/commit/3e51a5f9bf14feae1fc9fd72d55854e4ea3bfaca) 17354 fix import with custom-field - [`098d250`](https://github.com/netbox-community/netbox/commit/098d250552f9ab7317f62e71ee52b27191923944) 17354 change to use kwargs ### 📊 Changes **1 file changed** (+18 additions, -12 deletions) <details> <summary>View changed files</summary> 📝 `netbox/extras/models/customfields.py` (+18 -12) </details> ### 📄 Description ### Fixes: #17354 Only DynamicModelChoiceField has query_params, CSVModelChoiceField does not so this only includes the parameter if the field is of the correct type. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 00:19:49 +01:00
adam closed this issue 2025-12-30 00:19:49 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
beta
breaking change
complexity: high
complexity: low
complexity: medium
needs milestone
netbox
pending closure
plugin candidate
pull-request
Mirrored from GitHub Pull Request
 severity: high
severity: low
severity: medium
status: accepted
status: backlog
status: blocked
status: duplicate
status: needs owner
status: needs triage
status: revisions needed
status: under review
topic: GraphQL
topic: Internationalization
topic: OpenAPI
topic: UI/UX
topic: cabling
topic: event rules
topic: htmx navigation
topic: industrialization
topic: migrations
topic: plugins
topic: scripts
topic: templating
topic: testing
type: bug
type: deprecation
type: documentation
type: feature
type: housekeeping
type: translation
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/netbox#15078
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?